Skip to content

fix(IncrementalLoad): Do not attempt to delete files not in the datase #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cambot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(IncrementalLoad): Do not attempt to delete files not in the datase #931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7431db8
fix(IncrementalLoad): Do not attempt to delete files not in the datab…
cambot Feb 17, 2026
b6ef283
docs: update changelog. (#928)
cambot Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Fixed
- Fixed issue where Generated Files Read-only option didn't entirely work for files not in source control (#712)
- Fixed issue where a deleted file not within Embedded Git's management was causing the pull handler to crash and not fully update the Iris instance (#928)

## [2.15.0] - 2026-01-06

Expand Down
4 changes: 4 additions & 0 deletions cls/SourceControl/Git/PullEventHandler/IncrementalLoad.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ Method OnPull() As %Status
} elseif (..ModifiedFiles(i).changeType = "D") {
#; Deleted production items will not have an internal name
set delIndex = $select(##class(SourceControl.Git.Util.Production).ItemIsPTD(tExternalName): 1, 1: 2)
if ((delIndex = 2) && (internalName = "")) {
write !, tExternalName, "was not in the database. Nothing to delete."
Copy link
Collaborator

@isc-pbarton isc-pbarton Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny formatting nitpick, we'll want a space here

Suggested change
write !, tExternalName, "was not in the database. Nothing to delete."
write !, tExternalName, " was not in the database. Nothing to delete."

continue
}
set:(delIndex=1) internalName = "-"_i ;; This is a total hack because deleted production items will not have an internal name
set delList(delIndex, internalName) = tExternalName
} else {
Expand Down
Loading