fix(IncrementalLoad): Do not attempt to delete files not in the datase#931
Open
cambot wants to merge 2 commits intointersystems:mainfrom
Open
fix(IncrementalLoad): Do not attempt to delete files not in the datase#931cambot wants to merge 2 commits intointersystems:mainfrom
cambot wants to merge 2 commits intointersystems:mainfrom
Conversation
cambot
requested review from
isc-dchui,
isc-pbarton and
isc-tleavitt
as code owners
isc-pbarton
requested changes
Feb 18, 2026
Collaborator
isc-pbarton
left a comment
isc-pbarton
left a comment
There was a problem hiding this comment.
One nitpick here, otherwise looks great
| #; Deleted production items will not have an internal name | ||
| set delIndex = $select(##class(SourceControl.Git.Util.Production).ItemIsPTD(tExternalName): 1, 1: 2) | ||
| if ((delIndex = 2) && (internalName = "")) { | ||
| write !, tExternalName, "was not in the database. Nothing to delete." |
Collaborator
There was a problem hiding this comment.
tiny formatting nitpick, we'll want a space here
Suggested change
| write !, tExternalName, "was not in the database. Nothing to delete." | |
| write !, tExternalName, " was not in the database. Nothing to delete." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #928: the Incremental Load pull handler so that when applying commits results in deleting a file not managed by
embedded-git-config.json, do not crash with a<SUBSCRIPT>error.Test Plan
Examples of files you might have in your repository that embedded git won't sync into Iris:
The easiest way to reproduce this issue is to create a branch that adds (commits) one or more of these files, then change branches to/from this branch. (no need to merge into the main branch.)
You could also push this branch to a remote, reset your local to before this branch, then "Pull changes", but it's the same mechanism under the hood as "Check out branch"