Update dependencies and improve cache handling#30
Merged
ppenna merged 1 commit intohyperlight-dev:mainfrom Feb 11, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the nanvix dependency and refactors workload execution and cache handling to rely more on the nanvix::registry::Registry API, including ensuring interpreter packages are installed for scripted workloads.
Changes:
- Add
WorkloadType::package_name()and install interpreter packages before running scripted workloads. - Refactor cache lookup helpers to use
Registrymethods instead of direct filesystem path checks. - Bump the
nanvixgit revision (and update the lockfile accordingly).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/runtime.rs |
Adds workload→package mapping and installs scripted workload dependencies before resolving interpreter binaries. |
src/cache.rs |
Replaces filesystem cache probing with Registry calls and adds a synchronous cache check via a Tokio runtime. |
Cargo.toml |
Updates the nanvix git revision. |
Cargo.lock |
Lockfile refresh for the new nanvix revision and its transitive dependency changes. |
Comments suppressed due to low confidence (1)
src/runtime.rs:188
- Calling
registry.install(...)insideRuntime::runcan make normal execution (and the integration tests that callrun) depend on registry availability/network on every invocation. If the intent is only to ensure dependencies exist, consider making this step conditional (e.g., only when the interpreter binary/package is missing) or providing an option/env var to skip/avoid installs in offline/test environments.
if let Some(package_name) = workload_type.package_name() {
log::info!("Installing package '{}' and dependencies...", package_name);
self.registry
.install(machine_type, deployment_type, package_name, true)
.await?;
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
85acd53 to
3d28251
Compare
danbugs
approved these changes
Feb 10, 2026
f44adfe to
72b4ea1
Compare
Signed-off-by: Pedro Henrique Penna <ppenna@microsoft.com>
72b4ea1 to
b81e97d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements focused on cache management and workload package handling. The main changes are a refactor of cache lookup logic to use the
RegistryAPI, the addition of logic to ensure interpreter packages are installed for scripted workloads, and a utility method for mapping workload types to package names.