Skip to content

Fix: Remove validation from hypercert get call #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aspiers merged 2 commits into from
Jan 9, 2026
+10 −6
Merged

Fix: Remove validation from hypercert get call #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48ecd6c
fix: remove validation from get cert call
Kzoeps Jan 9, 2026
e968064
feat: update README to include `servers` in `createATProtoSDK`
Kzoeps Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-remove-validation-from-hypercert-get.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hypercerts-org/sdk-core": patch
---

Remove validation from hypercert.get
5 changes: 5 additions & 0 deletions packages/sdk-core/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ const sdk = createATProtoSDK({
jwksUri: "https://your-app.com/jwks.json",
jwkPrivate: process.env.ATPROTO_JWK_PRIVATE!,
},
// set up with your pds url.
// entryway doesn't work for this. Has to be a PDS URL.
servers: {
pds: "https://pds-eu-west4.test.certified.app",
},
});

// 2. Authenticate user
Expand Down
6 changes: 0 additions & 6 deletions packages/sdk-core/src/repository/HypercertOperationsImpl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,12 +638,6 @@ export class HypercertOperationsImpl extends EventEmitter<HypercertEvents> imple
throw new NetworkError("Failed to get hypercert");
}

// Validate with lexicon (more lenient - doesn't require $type)
const validation = validate(result.data.value, HYPERCERT_COLLECTIONS.CLAIM, "main", false);
if (!validation.success) {
throw new ValidationError(`Invalid hypercert record format: ${validation.error?.message}`);
}

return {
uri: result.data.uri,
cid: result.data.cid ?? "",
Expand Down