-
Notifications
You must be signed in to change notification settings - Fork 2
Fix: Remove validation from hypercert get call #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: e968064 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📝 WalkthroughWalkthroughRemoves post-fetch lexicon validation from hypercert.get(), updates SDK Core README to add an explicit PDS server configuration example, and adds a changeset entry marking a patch release for "@hypercerts-org/sdk-core". Changes
Sequence Diagram(s)(omitted — changes are a small bugfix and documentation update, not a new multi-component flow) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
92eef31 to
e968064
Compare
aspiers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All LGTM, thanks! I rebased and tidied up the git commits for cleaner history:
- Squashed the changeset commit and prettier commit into the remove
.get()validation commit, as these are all part of the same logical change. - Made the commit message more informative than "Update README".
Remove the lexicon validation from
repo.hypercerts.get(uri)call because the lexicon expects creation params with$typefor the image. But Atproto returns a BlobRef instead of what the lexicon expects.Also I think it doesnt really make sense to run validation on a get call when we've technically already run it on creation. It runs successfully on the
listcall since theres no validation and it should be uniform.Updated the docs to reflect the requirement of PDS url in sdk config.
Fixes #78
Summary by CodeRabbit
Bug Fixes
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.