Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/frameworks/html-vite/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"prep": "jiti ../../../scripts/prepare/bundle.ts"
},
"dependencies": {
"@storybook/builder-vite": "workspace:*",
"@storybook/builder-vite": "0.1.22",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The dependency @storybook/builder-vite has been changed from workspace:* to a fixed version 0.1.22. In a monorepo setup, workspace:* is typically used to reference local packages, which for @storybook/builder-vite appears to be version 8.3.0-beta.3 as seen in code/builders/builder-vite/package.json. This change means html-vite will now depend on an external 0.1.22 version instead of the local monorepo version. This is a significant deviation from typical monorepo dependency management and could lead to compatibility issues, unexpected behavior, or build failures if the external 0.1.22 version is not compatible with the rest of the monorepo or lacks features present in the local 8.3.0-beta.3 version. It's crucial to ensure that this external dependency is the correct and intended version for this package within the monorepo.

"@storybook/html": "workspace:*",
"magic-string": "^0.30.0"
},
Expand Down
Loading