Skip to content

Conversation

@q1blue
Copy link

@q1blue q1blue commented Jan 20, 2026

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • code/frameworks/html-vite/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Improper Handling of Unicode Encoding
SNYK-JS-TAR-15038581
  210  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical security concern by automatically upgrading a core dependency, @storybook/builder-vite, to a patched version. The change aims to mitigate a known vulnerability, thereby enhancing the project's overall security. While the primary dependency manifest is updated, a manual step is highlighted for yarn.lock to ensure full resolution for all dependency management scenarios.

Highlights

  • Security Upgrade: Upgraded the @storybook/builder-vite dependency from 0.0.0-use.local to 0.1.22 to fix a medium-severity vulnerability (SNYK-JS-TAR-15038581) related to 'Improper Handling of Unicode Encoding'.
  • Dependency Versioning: The package.json file was updated to explicitly define the new version for @storybook/builder-vite, moving from a workspace:* reference to a fixed version 0.1.22.
  • Yarn Lock File Warning: A warning indicates that the yarn.lock file failed to update automatically and requires manual intervention, especially for projects utilizing Yarn's zero-installs feature.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to upgrade the @storybook/builder-vite dependency to 0.1.22 in code/frameworks/html-vite/package.json to address a security vulnerability. However, the change from a workspace:* dependency to a fixed version 0.1.22 is a significant alteration in how this dependency is resolved within the monorepo, potentially introducing compatibility issues. Additionally, the pull request description indicates that yarn.lock failed to update, which will require manual intervention to ensure the security fix is fully applied and the project remains functional.

},
"dependencies": {
"@storybook/builder-vite": "workspace:*",
"@storybook/builder-vite": "0.1.22",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The dependency @storybook/builder-vite has been changed from workspace:* to a fixed version 0.1.22. In a monorepo setup, workspace:* is typically used to reference local packages, which for @storybook/builder-vite appears to be version 8.3.0-beta.3 as seen in code/builders/builder-vite/package.json. This change means html-vite will now depend on an external 0.1.22 version instead of the local monorepo version. This is a significant deviation from typical monorepo dependency management and could lead to compatibility issues, unexpected behavior, or build failures if the external 0.1.22 version is not compatible with the rest of the monorepo or lacks features present in the local 8.3.0-beta.3 version. It's crucial to ensure that this external dependency is the correct and intended version for this package within the monorepo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants