-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade @storybook/builder-vite from 0.0.0-use.local to 0.1.22 #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15038581
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical security concern by automatically upgrading a core dependency, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to upgrade the @storybook/builder-vite dependency to 0.1.22 in code/frameworks/html-vite/package.json to address a security vulnerability. However, the change from a workspace:* dependency to a fixed version 0.1.22 is a significant alteration in how this dependency is resolved within the monorepo, potentially introducing compatibility issues. Additionally, the pull request description indicates that yarn.lock failed to update, which will require manual intervention to ensure the security fix is fully applied and the project remains functional.
| }, | ||
| "dependencies": { | ||
| "@storybook/builder-vite": "workspace:*", | ||
| "@storybook/builder-vite": "0.1.22", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency @storybook/builder-vite has been changed from workspace:* to a fixed version 0.1.22. In a monorepo setup, workspace:* is typically used to reference local packages, which for @storybook/builder-vite appears to be version 8.3.0-beta.3 as seen in code/builders/builder-vite/package.json. This change means html-vite will now depend on an external 0.1.22 version instead of the local monorepo version. This is a significant deviation from typical monorepo dependency management and could lead to compatibility issues, unexpected behavior, or build failures if the external 0.1.22 version is not compatible with the rest of the monorepo or lacks features present in the local 8.3.0-beta.3 version. It's crucial to ensure that this external dependency is the correct and intended version for this package within the monorepo.
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
code/frameworks/html-vite/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15038581
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.