Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/frameworks/html-webpack5/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"prep": "jiti ../../../scripts/prepare/bundle.ts"
},
"dependencies": {
"@storybook/builder-webpack5": "workspace:*",
"@storybook/builder-webpack5": "7.1.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The change from "workspace:*" to "7.1.0" for @storybook/builder-webpack5 appears to be a major version downgrade. The code/builders/builder-webpack5/package.json file indicates that the version within the workspace is 8.3.0-beta.3. Downgrading to an older major version can lead to unexpected breaking changes, compatibility issues, or loss of features/fixes present in the newer 8.x.x series. Please confirm if this downgrade is intentional and if 7.1.0 is indeed the correct target for the security fix, especially if the 8.3.0-beta.3 version already contains the necessary patch or a newer fix. If the intention is to maintain the latest version within the monorepo, this change should be reverted.

"@storybook/builder-webpack5": "workspace:*"

"@storybook/global": "^5.0.0",
"@storybook/html": "workspace:*",
"@storybook/preset-html-webpack": "workspace:*",
Expand Down
Loading