Skip to content

Conversation

@q1blue
Copy link

@q1blue q1blue commented Jan 20, 2026

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • code/frameworks/html-webpack5/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Improper Handling of Unicode Encoding
SNYK-JS-TAR-15038581
  210  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the project's security posture by performing an automated upgrade of a critical Storybook dependency. The change directly addresses a known vulnerability, ensuring that the application leverages a more secure version of the package. While the core dependency update is straightforward, a manual step is highlighted for yarn.lock to complete the remediation process.

Highlights

  • Security Upgrade: This pull request, automatically generated by Snyk, upgrades the @storybook/builder-webpack5 dependency from 0.0.0-use.local to 7.1.0. This update is crucial for fixing a medium-severity vulnerability (SNYK-JS-TAR-15038581) related to improper handling of Unicode encoding.
  • Dependency Version Update: The package.json file for code/frameworks/html-webpack5 has been modified to reflect the new, secure version of @storybook/builder-webpack5.
  • Manual yarn.lock Update Required: A warning indicates that the yarn.lock file failed to update automatically and requires manual intervention to ensure dependency consistency, especially for projects utilizing Yarn's zero-installs feature.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to address a security vulnerability by upgrading @storybook/builder-webpack5. However, the proposed change involves downgrading the package from its current workspace:* version (which resolves to 8.3.0-beta.3 within the monorepo) to 7.1.0. This major version downgrade could introduce significant breaking changes or regressions. It is crucial to verify if this downgrade is intentional and compatible with the project's current state and other monorepo packages. Additionally, the PR description highlights a critical issue where the yarn.lock file failed to update. This must be manually resolved to ensure dependency consistency and reproducible builds, otherwise, the vulnerability might not be fully mitigated, or new issues could arise.

},
"dependencies": {
"@storybook/builder-webpack5": "workspace:*",
"@storybook/builder-webpack5": "7.1.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The change from "workspace:*" to "7.1.0" for @storybook/builder-webpack5 appears to be a major version downgrade. The code/builders/builder-webpack5/package.json file indicates that the version within the workspace is 8.3.0-beta.3. Downgrading to an older major version can lead to unexpected breaking changes, compatibility issues, or loss of features/fixes present in the newer 8.x.x series. Please confirm if this downgrade is intentional and if 7.1.0 is indeed the correct target for the security fix, especially if the 8.3.0-beta.3 version already contains the necessary patch or a newer fix. If the intention is to maintain the latest version within the monorepo, this change should be reverted.

"@storybook/builder-webpack5": "workspace:*"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants