-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade @storybook/builder-webpack5 from 0.0.0-use.local to 7.1.0 #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
…ties The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15038581
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the project's security posture by performing an automated upgrade of a critical Storybook dependency. The change directly addresses a known vulnerability, ensuring that the application leverages a more secure version of the package. While the core dependency update is straightforward, a manual step is highlighted for Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to address a security vulnerability by upgrading @storybook/builder-webpack5. However, the proposed change involves downgrading the package from its current workspace:* version (which resolves to 8.3.0-beta.3 within the monorepo) to 7.1.0. This major version downgrade could introduce significant breaking changes or regressions. It is crucial to verify if this downgrade is intentional and compatible with the project's current state and other monorepo packages. Additionally, the PR description highlights a critical issue where the yarn.lock file failed to update. This must be manually resolved to ensure dependency consistency and reproducible builds, otherwise, the vulnerability might not be fully mitigated, or new issues could arise.
| }, | ||
| "dependencies": { | ||
| "@storybook/builder-webpack5": "workspace:*", | ||
| "@storybook/builder-webpack5": "7.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change from "workspace:*" to "7.1.0" for @storybook/builder-webpack5 appears to be a major version downgrade. The code/builders/builder-webpack5/package.json file indicates that the version within the workspace is 8.3.0-beta.3. Downgrading to an older major version can lead to unexpected breaking changes, compatibility issues, or loss of features/fixes present in the newer 8.x.x series. Please confirm if this downgrade is intentional and if 7.1.0 is indeed the correct target for the security fix, especially if the 8.3.0-beta.3 version already contains the necessary patch or a newer fix. If the intention is to maintain the latest version within the monorepo, this change should be reverted.
"@storybook/builder-webpack5": "workspace:*"
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
code/frameworks/html-webpack5/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15038581
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.