Skip to content

[Snyk] Fix for 6 vulnerabilities #10432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 6 vulnerabilities #10432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/test-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@
"start": "backstage-cli package start"
},
"dependencies": {
"@backstage/config": "workspace:^",
"@backstage/core-app-api": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/core-app-api": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-react": "workspace:^",
"@backstage/plugin-permission-react": "0.1.0",
Comment on lines +48 to +52
Copy link

@gemini-code-assist gemini-code-assist bot Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The change from workspace:^ to pinned old versions for these @backstage packages is incorrect and will likely cause significant issues in this monorepo.

The workspace:^ protocol ensures that this package uses the current versions of other packages from within this same repository. By replacing it with hardcoded older versions, you are breaking this link. For example:

  • @backstage/config is at version 1.0.8 in the workspace, but this change pins it to 0.1.1.
  • @backstage/core-app-api is at 1.9.1-next.0, but is pinned to 0.1.0.
  • @backstage/core-plugin-api is at 1.5.3, but is pinned to 0.1.0.

These are major downgrades that will likely lead to build failures, test failures, or runtime errors due to API incompatibilities and version mismatches with other packages in the monorepo.

While the intent is to fix security vulnerabilities, this approach is incorrect. The vulnerabilities should be addressed by updating the transitive dependencies that contain them, potentially using resolutions in the root package.json to force a specific version of a vulnerable sub-dependency across the entire workspace.

I recommend reverting these changes. The Snyk PR itself notes that it "Failed to update the yarn.lock", which is a strong indicator that these changes are problematic.

    "@backstage/config": "workspace:^",
    "@backstage/core-app-api": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/plugin-permission-common": "workspace:^",
    "@backstage/plugin-permission-react": "workspace:^"

"@backstage/theme": "workspace:^",
"@backstage/types": "workspace:^",
"@material-ui/core": "^4.12.2",
Expand Down
Loading