[Snyk] Fix for 6 vulnerabilities #10432
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15038581 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-14908844 - https://snyk.io/vuln/SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291 - https://snyk.io/vuln/SNYK-JS-LODASH-15053838 - https://snyk.io/vuln/SNYK-JS-LODASHES-15053836 - https://snyk.io/vuln/SNYK-JS-DIFF-14917201
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the security posture of the project by resolving six identified vulnerabilities within its yarn dependencies. The changes involve updating specific Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, attempts to fix security vulnerabilities by changing dependency versions in packages/test-utils/package.json. However, the proposed changes are incorrect and will likely break the project. It replaces monorepo workspace links (workspace:^) with pinned, much older versions of core packages. This is a significant downgrade that will introduce version conflicts and incompatibilities. I have provided a critical review comment explaining the issue and suggesting that the changes be reverted. The vulnerabilities should be addressed by other means, such as using resolutions to update the specific transitive dependencies.
| "@backstage/config": "0.1.1", | ||
| "@backstage/core-app-api": "0.1.0", | ||
| "@backstage/core-plugin-api": "0.1.0", | ||
| "@backstage/plugin-permission-common": "workspace:^", | ||
| "@backstage/plugin-permission-react": "workspace:^", | ||
| "@backstage/plugin-permission-react": "0.1.0", |
There was a problem hiding this comment.
The change from workspace:^ to pinned old versions for these @backstage packages is incorrect and will likely cause significant issues in this monorepo.
The workspace:^ protocol ensures that this package uses the current versions of other packages from within this same repository. By replacing it with hardcoded older versions, you are breaking this link. For example:
@backstage/configis at version1.0.8in the workspace, but this change pins it to0.1.1.@backstage/core-app-apiis at1.9.1-next.0, but is pinned to0.1.0.@backstage/core-plugin-apiis at1.5.3, but is pinned to0.1.0.
These are major downgrades that will likely lead to build failures, test failures, or runtime errors due to API incompatibilities and version mismatches with other packages in the monorepo.
While the intent is to fix security vulnerabilities, this approach is incorrect. The vulnerabilities should be addressed by updating the transitive dependencies that contain them, potentially using resolutions in the root package.json to force a specific version of a vulnerable sub-dependency across the entire workspace.
I recommend reverting these changes. The Snyk PR itself notes that it "Failed to update the yarn.lock", which is a strong indicator that these changes are problematic.
"@backstage/config": "workspace:^",
"@backstage/core-app-api": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-react": "workspace:^"
WalkthroughThis PR updates the dependency management strategy for the Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Dev as Developer
participant TestUtils as @backstage/test-utils
participant PM as Package Manager
participant Deps as External Dependencies
Note over Dev,Deps: Dependency Version Update Process
Dev->>TestUtils: Update package.json
Note right of TestUtils: Change workspace:^ to<br/>specific versions:<br/>- config: 0.1.1<br/>- core-app-api: 0.1.0<br/>- core-plugin-api: 0.1.0<br/>- permission-react: 0.1.0
Dev->>PM: Run install command
PM->>Deps: Resolve dependencies
Deps-->>PM: Return pinned versions
PM->>TestUtils: Install specific versions
PM-->>Dev: Dependencies updated
Note over TestUtils,Deps: Now uses fixed versions<br/>instead of workspace references
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
Snyk has created this PR to fix 6 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
packages/test-utils/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15038581
SNYK-JS-ELLIPTIC-14908844
SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291
SNYK-JS-LODASH-15053838
SNYK-JS-LODASHES-15053836
SNYK-JS-DIFF-14917201
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution
EntelligenceAI PR Summary
This PR transitions test-utils package dependencies from workspace protocol references to explicit version numbers.
@backstage/configfromworkspace:^to version0.1.1@backstage/core-app-apifromworkspace:^to version0.1.0@backstage/core-plugin-apifromworkspace:^to version0.1.0@backstage/plugin-permission-reactfromworkspace:^to version0.1.0