Skip to content

[Snyk] Fix for 6 vulnerabilities #10428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 6 vulnerabilities #10428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/xcmetrics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Comment on lines +26 to +29
Copy link

@gemini-code-assist gemini-code-assist bot Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Pinning @backstage/core-components and @backstage/theme to specific, older versions instead of using workspace:^ is highly problematic in this monorepo setup. This change breaks the local package linking provided by Yarn workspaces, forcing the use of published, outdated versions from the registry instead of the current code in your repository.

  • @backstage/core-components is being downgraded from its workspace version (0.13.4-next.0) to 0.1.0.
  • @backstage/theme is being downgraded from its workspace version (0.4.1) to 0.1.1.

This will likely cause build failures, runtime errors, and inconsistencies with other packages in the monorepo. It's recommended to revert these changes and instead use Yarn's resolutions feature in the root package.json to force a specific version of the vulnerable transitive dependency across the entire workspace. This will fix the security issue without breaking your monorepo's structure.

Suggested change
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/theme": "workspace:^",

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
"lodash": "^4.17.21",
"lodash": "^4.17.23",
"luxon": "^3.0.0",
"react-use": "^17.2.4",
"recharts": "^2.5.0"
Expand Down
Loading