-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 6 vulnerabilities #10428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15038581 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-14908844 - https://snyk.io/vuln/SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291 - https://snyk.io/vuln/SNYK-JS-LODASH-15053838 - https://snyk.io/vuln/SNYK-JS-LODASHES-15053836 - https://snyk.io/vuln/SNYK-JS-DIFF-14917201
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the project's security posture by upgrading several key dependencies within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
⛔ Snyk checks have failed. 1 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
WalkthroughThis PR updates dependency management in the xcmetrics plugin package configuration. The changes transition two Backstage internal dependencies from workspace protocol references to fixed version pinning: Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Dev as Developer
participant PM as Package Manager
participant Registry as NPM Registry
participant Plugin as XCMetrics Plugin
Dev->>PM: Update package.json dependencies
Note over Dev,PM: @backstage/core-components: 0.1.0<br/>@backstage/theme: 0.1.1<br/>lodash: ^4.17.23
Dev->>PM: Run install command
PM->>Registry: Resolve @backstage/core-components@0.1.0
Registry-->>PM: Return package metadata
PM->>Registry: Resolve @backstage/theme@0.1.1
Registry-->>PM: Return package metadata
PM->>Registry: Resolve lodash@^4.17.23
Registry-->>PM: Return package metadata
PM->>PM: Calculate dependency tree
PM->>Registry: Download packages
Registry-->>PM: Package tarballs
PM->>Plugin: Install dependencies to node_modules
PM-->>Dev: Installation complete
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, aims to fix several security vulnerabilities by updating dependencies. While the update to lodash is appropriate for patching a known vulnerability, the changes to @backstage/core-components and @backstage/theme are problematic.
The PR replaces workspace:^ with pinned, older versions for these packages. This is a critical issue in a monorepo as it breaks the internal package linking mechanism of Yarn workspaces, potentially leading to build failures and runtime errors. The warning in the PR description about failing to update yarn.lock further indicates that these changes are not safe to merge as-is.
I've left a comment with a suggestion to revert these changes and proposed an alternative approach using Yarn's resolutions to address the transitive vulnerabilities without disrupting the monorepo structure.
| "@backstage/core-components": "0.1.0", | ||
| "@backstage/core-plugin-api": "workspace:^", | ||
| "@backstage/errors": "workspace:^", | ||
| "@backstage/theme": "workspace:^", | ||
| "@backstage/theme": "0.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinning @backstage/core-components and @backstage/theme to specific, older versions instead of using workspace:^ is highly problematic in this monorepo setup. This change breaks the local package linking provided by Yarn workspaces, forcing the use of published, outdated versions from the registry instead of the current code in your repository.
@backstage/core-componentsis being downgraded from its workspace version (0.13.4-next.0) to0.1.0.@backstage/themeis being downgraded from its workspace version (0.4.1) to0.1.1.
This will likely cause build failures, runtime errors, and inconsistencies with other packages in the monorepo. It's recommended to revert these changes and instead use Yarn's resolutions feature in the root package.json to force a specific version of the vulnerable transitive dependency across the entire workspace. This will fix the security issue without breaking your monorepo's structure.
| "@backstage/core-components": "0.1.0", | |
| "@backstage/core-plugin-api": "workspace:^", | |
| "@backstage/errors": "workspace:^", | |
| "@backstage/theme": "workspace:^", | |
| "@backstage/theme": "0.1.1", | |
| "@backstage/core-components": "workspace:^", | |
| "@backstage/core-plugin-api": "workspace:^", | |
| "@backstage/errors": "workspace:^", | |
| "@backstage/theme": "workspace:^", |
Snyk has created this PR to fix 6 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/xcmetrics/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15038581
SNYK-JS-ELLIPTIC-14908844
SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291
SNYK-JS-LODASH-15053838
SNYK-JS-LODASHES-15053836
SNYK-JS-DIFF-14917201
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution
EntelligenceAI PR Summary
This PR updates dependency versions in the xcmetrics plugin package configuration, transitioning from workspace protocol to fixed version pinning for Backstage dependencies and upgrading lodash for security.
@backstage/core-componentsfrom workspace protocol to fixed version0.1.0@backstage/themefrom workspace protocol to fixed version0.1.1lodashdependency from^4.17.21to^4.17.23to address security vulnerabilitiesplugins/xcmetrics/package.jsonto implement explicit version pinning