Skip to content

Conversation

@q1blue
Copy link
Collaborator

@q1blue q1blue commented Jan 22, 2026

snyk-top-banner

Snyk has created this PR to fix 6 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/xcmetrics/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Improper Handling of Unicode Encoding
SNYK-JS-TAR-15038581
  210  
medium severity Use of a Cryptographic Primitive with a Risky Implementation
SNYK-JS-ELLIPTIC-14908844
  146  
high severity UNIX Symbolic Link (Symlink) Following
SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291
  113  
medium severity Prototype Pollution
SNYK-JS-LODASH-15053838
  88  
medium severity Prototype Pollution
SNYK-JS-LODASHES-15053836
  88  
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-DIFF-14917201
  62  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution


EntelligenceAI PR Summary

This PR updates dependency versions in the xcmetrics plugin package configuration, transitioning from workspace protocol to fixed version pinning for Backstage dependencies and upgrading lodash for security.

  • Changed @backstage/core-components from workspace protocol to fixed version 0.1.0
  • Changed @backstage/theme from workspace protocol to fixed version 0.1.1
  • Upgraded lodash dependency from ^4.17.21 to ^4.17.23 to address security vulnerabilities
  • Modified plugins/xcmetrics/package.json to implement explicit version pinning

@codesandbox
Copy link

codesandbox bot commented Jan 22, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security posture by upgrading several key dependencies within the plugins/xcmetrics/package.json file. These updates specifically target and resolve six identified vulnerabilities, improving the overall robustness and safety of the application's dependencies.

Highlights

  • Dependency Updates: Updated @backstage/core-components to 0.1.0, @backstage/theme to 0.1.1, and lodash to ^4.17.23 in plugins/xcmetrics/package.json.
  • Vulnerability Fixes: Addressed 6 security vulnerabilities, including Improper Handling of Unicode Encoding (tar), Risky Cryptographic Implementation (elliptic), UNIX Symbolic Link Following (backstage), Prototype Pollution (lodash, lodashes), and Regular Expression Denial of Service (diff).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snyk-io
Copy link

snyk-io bot commented Jan 22, 2026

Snyk checks have failed. 1 issues have been found so far.

Status Scanner Critical High Medium Low Total (1)
Open Source Security 0 0 1 0 1 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@entelligence-ai-pr-reviews
Copy link

Walkthrough

This PR updates dependency management in the xcmetrics plugin package configuration. The changes transition two Backstage internal dependencies from workspace protocol references to fixed version pinning: @backstage/core-components is set to version 0.1.0 and @backstage/theme to version 0.1.1. Additionally, the lodash dependency is upgraded from ^4.17.21 to ^4.17.23, which addresses known security vulnerabilities in the previous version. These modifications represent a shift from monorepo workspace references to explicit version control for specific dependencies while maintaining the workspace protocol for other packages.

Changes

File(s) Summary
plugins/xcmetrics/package.json Updated dependency versions: changed @backstage/core-components from workspace protocol to 0.1.0, @backstage/theme from workspace protocol to 0.1.1, and upgraded lodash from ^4.17.21 to ^4.17.23 for security fixes.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant PM as Package Manager
    participant Registry as NPM Registry
    participant Plugin as XCMetrics Plugin

    Dev->>PM: Update package.json dependencies
    Note over Dev,PM: @backstage/core-components: 0.1.0<br/>@backstage/theme: 0.1.1<br/>lodash: ^4.17.23
    
    Dev->>PM: Run install command
    PM->>Registry: Resolve @backstage/core-components@0.1.0
    Registry-->>PM: Return package metadata
    PM->>Registry: Resolve @backstage/theme@0.1.1
    Registry-->>PM: Return package metadata
    PM->>Registry: Resolve lodash@^4.17.23
    Registry-->>PM: Return package metadata
    
    PM->>PM: Calculate dependency tree
    PM->>Registry: Download packages
    Registry-->>PM: Package tarballs
    
    PM->>Plugin: Install dependencies to node_modules
    PM-->>Dev: Installation complete
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix several security vulnerabilities by updating dependencies. While the update to lodash is appropriate for patching a known vulnerability, the changes to @backstage/core-components and @backstage/theme are problematic.

The PR replaces workspace:^ with pinned, older versions for these packages. This is a critical issue in a monorepo as it breaks the internal package linking mechanism of Yarn workspaces, potentially leading to build failures and runtime errors. The warning in the PR description about failing to update yarn.lock further indicates that these changes are not safe to merge as-is.

I've left a comment with a suggestion to revert these changes and proposed an alternative approach using Yarn's resolutions to address the transitive vulnerabilities without disrupting the monorepo structure.

Comment on lines +26 to +29
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Pinning @backstage/core-components and @backstage/theme to specific, older versions instead of using workspace:^ is highly problematic in this monorepo setup. This change breaks the local package linking provided by Yarn workspaces, forcing the use of published, outdated versions from the registry instead of the current code in your repository.

  • @backstage/core-components is being downgraded from its workspace version (0.13.4-next.0) to 0.1.0.
  • @backstage/theme is being downgraded from its workspace version (0.4.1) to 0.1.1.

This will likely cause build failures, runtime errors, and inconsistencies with other packages in the monorepo. It's recommended to revert these changes and instead use Yarn's resolutions feature in the root package.json to force a specific version of the vulnerable transitive dependency across the entire workspace. This will fix the security issue without breaking your monorepo's structure.

Suggested change
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/theme": "workspace:^",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants