Skip to content

[Snyk] Fix for 6 vulnerabilities #10427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

[Snyk] Fix for 6 vulnerabilities #10427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/scaffolder-node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/plugin-scaffolder-common": "workspace:^",
"@backstage/types": "workspace:^",
"@backstage/backend-plugin-api": "1.6.1",
"@backstage/catalog-model": "0.1.1",
"@backstage/plugin-scaffolder-common": "0.1.0",
"@backstage/types": "0.1.1",
Comment on lines +27 to +30
Copy link

@gemini-code-assist gemini-code-assist bot Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These automated dependency changes are incorrect and will break the project.

  1. Incorrect Dependency Management: It replaces workspace:^ specifiers with pinned versions. This goes against the yarn workspace convention used in this monorepo, which can lead to build failures and inconsistencies. Internal packages should reference each other using workspace:^ to ensure they use the versions from the local workspace.
  2. Severe Downgrades: It downgrades several critical packages to much older versions, which will introduce breaking changes and regressions. For example:
    • @backstage/catalog-model is downgraded from version 1.4.1 to 0.1.1.
    • @backstage/plugin-scaffolder-common is downgraded from a 1.x version to 0.1.0.
    • @backstage/types is downgraded from 1.1.0 to 0.1.1.
  3. Incomplete Change: As noted in the PR description, yarn.lock has not been updated. Merging this would leave the repository in a broken state.

These changes should be reverted. The vulnerabilities should be addressed manually by updating the packages within the workspace correctly.

    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/catalog-model": "workspace:^",
    "@backstage/plugin-scaffolder-common": "workspace:^",
    "@backstage/types": "workspace:^"

"jsonschema": "^1.2.6",
"winston": "^3.2.1",
"zod": "^3.21.4",
Expand Down
Loading