Skip to content

Conversation

@q1blue
Copy link
Collaborator

@q1blue q1blue commented Jan 22, 2026

snyk-top-banner

Snyk has created this PR to fix 6 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/scaffolder-node/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Improper Handling of Unicode Encoding
SNYK-JS-TAR-15038581
  210  
medium severity Use of a Cryptographic Primitive with a Risky Implementation
SNYK-JS-ELLIPTIC-14908844
  146  
high severity UNIX Symbolic Link (Symlink) Following
SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291
  113  
medium severity Prototype Pollution
SNYK-JS-LODASH-15053838
  88  
medium severity Prototype Pollution
SNYK-JS-LODASHES-15053836
  88  
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-DIFF-14917201
  62  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution


EntelligenceAI PR Summary

This PR transitions the scaffolder-node plugin from workspace protocol dependencies to pinned semantic versions for internal Backstage packages.

  • Updated @backstage/backend-plugin-api to version 1.6.1
  • Updated @backstage/catalog-model to version 0.1.1
  • Updated @backstage/plugin-scaffolder-common to version 0.1.0
  • Updated @backstage/types to version 0.1.1
  • Prepares package for independent publication or stable release

@codesandbox
Copy link

codesandbox bot commented Jan 22, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, focuses on enhancing the security posture of the project by resolving six identified vulnerabilities. The primary change involves updating several core Backstage dependencies within the plugins/scaffolder-node module to their latest secure versions, aiming to mitigate risks such as Prototype Pollution and Regular Expression Denial of Service.

Highlights

  • Automated Security Fix: This pull request was automatically generated by Snyk to address 6 identified vulnerabilities in the project's yarn dependencies.
  • Dependency Updates: Key dependencies within the plugins/scaffolder-node/package.json file have been updated to newer, more secure versions.
  • Manual yarn.lock Update Required: The yarn.lock file was not automatically updated by Snyk, requiring manual intervention to update it before merging this PR.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snyk-io
Copy link

snyk-io bot commented Jan 22, 2026

Snyk checks have failed. 1 issues have been found so far.

Status Scanner Critical High Medium Low Total (1)
Open Source Security 0 0 1 0 1 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@entelligence-ai-pr-reviews
Copy link

Walkthrough

This pull request updates the dependency management strategy for the scaffolder-node plugin by replacing workspace protocol references with explicit semantic version numbers. Four internal Backstage packages are affected: backend-plugin-api (1.6.1), catalog-model (0.1.1), plugin-scaffolder-common (0.1.0), and types (0.1.1). This transition from monorepo workspace dependencies to pinned versions indicates preparation for independent package publication or establishing a stable release version, ensuring consistent dependency resolution across different installation contexts.

Changes

File(s) Summary
plugins/scaffolder-node/package.json Replaced workspace protocol references with explicit semantic versions for four internal Backstage dependencies: @backstage/backend-plugin-api (1.6.1), @backstage/catalog-model (0.1.1), @backstage/plugin-scaffolder-common (0.1.0), and @backstage/types (0.1.1).

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Build as Build Process
    participant ScaffolderNode as scaffolder-node
    participant BackendAPI as backend-plugin-api (v1.6.1)
    participant CatalogModel as catalog-model (v0.1.1)
    participant ScaffolderCommon as plugin-scaffolder-common (v0.1.0)
    participant Types as types (v0.1.1)

    Note over Build,Types: Dependency Resolution During Build

    Build->>ScaffolderNode: Install dependencies
    activate ScaffolderNode
    
    ScaffolderNode->>BackendAPI: Resolve version 1.6.1
    activate BackendAPI
    BackendAPI-->>ScaffolderNode: Package resolved
    deactivate BackendAPI
    
    ScaffolderNode->>CatalogModel: Resolve version 0.1.1
    activate CatalogModel
    CatalogModel-->>ScaffolderNode: Package resolved
    deactivate CatalogModel
    
    ScaffolderNode->>ScaffolderCommon: Resolve version 0.1.0
    activate ScaffolderCommon
    ScaffolderCommon-->>ScaffolderNode: Package resolved
    deactivate ScaffolderCommon
    
    ScaffolderNode->>Types: Resolve version 0.1.1
    activate Types
    Types-->>ScaffolderNode: Package resolved
    deactivate Types
    
    ScaffolderNode-->>Build: Dependencies installed
    deactivate ScaffolderNode
    
    Note over Build,Types: Changed from workspace:^ to fixed versions
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

@socket-security
Copy link

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
License policy violation: npm atob under CC-BY-3.0

License: CC-BY-3.0 - the applicable license policy does not allow this license (4) (package/LICENSE.DOCS)

From: ?npm/atob@2.1.2

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/atob@2.1.2. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix several security vulnerabilities by updating dependencies. However, the proposed changes are fundamentally flawed and should not be merged. The PR incorrectly replaces workspace:^ dependency specifiers with pinned versions, which is contrary to the project's monorepo setup. Critically, it downgrades several key @backstage packages to much older versions, which will certainly introduce breaking changes and regressions. Furthermore, the yarn.lock file has not been updated, rendering the change incomplete. I have added a comment with a suggestion to revert these changes. The vulnerabilities should be addressed manually in a way that respects the project's workspace architecture.

Comment on lines +27 to +30
"@backstage/backend-plugin-api": "1.6.1",
"@backstage/catalog-model": "0.1.1",
"@backstage/plugin-scaffolder-common": "0.1.0",
"@backstage/types": "0.1.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These automated dependency changes are incorrect and will break the project.

  1. Incorrect Dependency Management: It replaces workspace:^ specifiers with pinned versions. This goes against the yarn workspace convention used in this monorepo, which can lead to build failures and inconsistencies. Internal packages should reference each other using workspace:^ to ensure they use the versions from the local workspace.
  2. Severe Downgrades: It downgrades several critical packages to much older versions, which will introduce breaking changes and regressions. For example:
    • @backstage/catalog-model is downgraded from version 1.4.1 to 0.1.1.
    • @backstage/plugin-scaffolder-common is downgraded from a 1.x version to 0.1.0.
    • @backstage/types is downgraded from 1.1.0 to 0.1.1.
  3. Incomplete Change: As noted in the PR description, yarn.lock has not been updated. Merging this would leave the repository in a broken state.

These changes should be reverted. The vulnerabilities should be addressed manually by updating the packages within the workspace correctly.

    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/catalog-model": "workspace:^",
    "@backstage/plugin-scaffolder-common": "workspace:^",
    "@backstage/types": "workspace:^"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants