-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 6 vulnerabilities #10427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15038581 - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-14908844 - https://snyk.io/vuln/SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291 - https://snyk.io/vuln/SNYK-JS-LODASH-15053838 - https://snyk.io/vuln/SNYK-JS-LODASHES-15053836 - https://snyk.io/vuln/SNYK-JS-DIFF-14917201
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, focuses on enhancing the security posture of the project by resolving six identified vulnerabilities. The primary change involves updating several core Backstage dependencies within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
⛔ Snyk checks have failed. 1 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
WalkthroughThis pull request updates the dependency management strategy for the scaffolder-node plugin by replacing workspace protocol references with explicit semantic version numbers. Four internal Backstage packages are affected: backend-plugin-api (1.6.1), catalog-model (0.1.1), plugin-scaffolder-common (0.1.0), and types (0.1.1). This transition from monorepo workspace dependencies to pinned versions indicates preparation for independent package publication or establishing a stable release version, ensuring consistent dependency resolution across different installation contexts. Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Build as Build Process
participant ScaffolderNode as scaffolder-node
participant BackendAPI as backend-plugin-api (v1.6.1)
participant CatalogModel as catalog-model (v0.1.1)
participant ScaffolderCommon as plugin-scaffolder-common (v0.1.0)
participant Types as types (v0.1.1)
Note over Build,Types: Dependency Resolution During Build
Build->>ScaffolderNode: Install dependencies
activate ScaffolderNode
ScaffolderNode->>BackendAPI: Resolve version 1.6.1
activate BackendAPI
BackendAPI-->>ScaffolderNode: Package resolved
deactivate BackendAPI
ScaffolderNode->>CatalogModel: Resolve version 0.1.1
activate CatalogModel
CatalogModel-->>ScaffolderNode: Package resolved
deactivate CatalogModel
ScaffolderNode->>ScaffolderCommon: Resolve version 0.1.0
activate ScaffolderCommon
ScaffolderCommon-->>ScaffolderNode: Package resolved
deactivate ScaffolderCommon
ScaffolderNode->>Types: Resolve version 0.1.1
activate Types
Types-->>ScaffolderNode: Package resolved
deactivate Types
ScaffolderNode-->>Build: Dependencies installed
deactivate ScaffolderNode
Note over Build,Types: Changed from workspace:^ to fixed versions
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, aims to fix several security vulnerabilities by updating dependencies. However, the proposed changes are fundamentally flawed and should not be merged. The PR incorrectly replaces workspace:^ dependency specifiers with pinned versions, which is contrary to the project's monorepo setup. Critically, it downgrades several key @backstage packages to much older versions, which will certainly introduce breaking changes and regressions. Furthermore, the yarn.lock file has not been updated, rendering the change incomplete. I have added a comment with a suggestion to revert these changes. The vulnerabilities should be addressed manually in a way that respects the project's workspace architecture.
| "@backstage/backend-plugin-api": "1.6.1", | ||
| "@backstage/catalog-model": "0.1.1", | ||
| "@backstage/plugin-scaffolder-common": "0.1.0", | ||
| "@backstage/types": "0.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These automated dependency changes are incorrect and will break the project.
- Incorrect Dependency Management: It replaces
workspace:^specifiers with pinned versions. This goes against the yarn workspace convention used in this monorepo, which can lead to build failures and inconsistencies. Internal packages should reference each other usingworkspace:^to ensure they use the versions from the local workspace. - Severe Downgrades: It downgrades several critical packages to much older versions, which will introduce breaking changes and regressions. For example:
@backstage/catalog-modelis downgraded from version1.4.1to0.1.1.@backstage/plugin-scaffolder-commonis downgraded from a1.xversion to0.1.0.@backstage/typesis downgraded from1.1.0to0.1.1.
- Incomplete Change: As noted in the PR description,
yarn.lockhas not been updated. Merging this would leave the repository in a broken state.
These changes should be reverted. The vulnerabilities should be addressed manually by updating the packages within the workspace correctly.
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/plugin-scaffolder-common": "workspace:^",
"@backstage/types": "workspace:^"
Snyk has created this PR to fix 6 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/scaffolder-node/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15038581
SNYK-JS-ELLIPTIC-14908844
SNYK-JS-BACKSTAGEBACKENDPLUGINAPI-15054291
SNYK-JS-LODASH-15053838
SNYK-JS-LODASHES-15053836
SNYK-JS-DIFF-14917201
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Prototype Pollution
EntelligenceAI PR Summary
This PR transitions the scaffolder-node plugin from workspace protocol dependencies to pinned semantic versions for internal Backstage packages.
@backstage/backend-plugin-apito version 1.6.1@backstage/catalog-modelto version 0.1.1@backstage/plugin-scaffolder-commonto version 0.1.0@backstage/typesto version 0.1.1