Skip to content

[Snyk] Security upgrade @backstage/theme from 0.0.0-use.local to 0.1.1 #10355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade @backstage/theme from 0.0.0-use.local to 0.1.1 #10355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/bitrise/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Copy link

@gemini-code-assist gemini-code-assist bot Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change pins @backstage/theme to version 0.1.1, replacing the workspace:^ specifier. This is problematic for a few reasons:

  1. Breaks Monorepo Structure: This project uses Yarn workspaces, and workspace:^ ensures that the local version of @backstage/theme from this monorepo is used. Hardcoding a version breaks this convention.
  2. Significant Downgrade: The version of @backstage/theme in this workspace is 0.4.1 (as seen in packages/theme/package.json). Pinning to 0.1.1 is a major downgrade and will likely introduce breaking changes or inconsistencies.
  3. Dependency Issues: The PR description notes that yarn.lock failed to update, which strongly suggests this change creates dependency resolution issues.

While this PR aims to fix a security vulnerability, this is not the correct way to do it. The Snyk scanner likely misinterpreted the workspace:^ version. The correct fix is to ensure the workspace version of @backstage/theme (0.4.1) is not vulnerable. It's recommended to revert this change and investigate the Snyk report again, or update the workspace package if needed.

Suggested change
"@backstage/theme": "0.1.1",
"@backstage/theme": "workspace:^",

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading