-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Security upgrade @backstage/theme from 0.0.0-use.local to 0.1.1 #10355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TAR-15038581
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, implements a security upgrade for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, aims to fix a security vulnerability by changing the version of @backstage/theme. However, the proposed change from workspace:^ to a pinned, old version (0.1.1) is incorrect for this monorepo setup. It constitutes a significant downgrade from the current workspace version (0.4.1), breaks the workspace protocol, and is likely to cause build failures or runtime issues, as indicated by the yarn.lock update failure mentioned in the PR description. I have recommended reverting this change.
| "@backstage/core-plugin-api": "workspace:^", | ||
| "@backstage/plugin-catalog-react": "workspace:^", | ||
| "@backstage/theme": "workspace:^", | ||
| "@backstage/theme": "0.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change pins @backstage/theme to version 0.1.1, replacing the workspace:^ specifier. This is problematic for a few reasons:
- Breaks Monorepo Structure: This project uses Yarn workspaces, and
workspace:^ensures that the local version of@backstage/themefrom this monorepo is used. Hardcoding a version breaks this convention. - Significant Downgrade: The version of
@backstage/themein this workspace is0.4.1(as seen inpackages/theme/package.json). Pinning to0.1.1is a major downgrade and will likely introduce breaking changes or inconsistencies. - Dependency Issues: The PR description notes that
yarn.lockfailed to update, which strongly suggests this change creates dependency resolution issues.
While this PR aims to fix a security vulnerability, this is not the correct way to do it. The Snyk scanner likely misinterpreted the workspace:^ version. The correct fix is to ensure the workspace version of @backstage/theme (0.4.1) is not vulnerable. It's recommended to revert this change and investigate the Snyk report again, or update the workspace package if needed.
| "@backstage/theme": "0.1.1", | |
| "@backstage/theme": "workspace:^", |
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/bitrise/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TAR-15038581
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.