Skip to content

Fix elementhandle-wait-for-element-state headful test failures #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kblok wants to merge 1 commit into from
Closed

Fix elementhandle-wait-for-element-state headful test failures #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/PlaywrightSharp.Nunit/TestExpectations/TestExpectations.local.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,12 +191,6 @@
"parameters": ["headful"],
"expectations": ["FAIL"]
},
{
"testIdPattern": "[elementhandle-wait-for-element-state.spec.ts] *",
"platforms": ["darwin", "linux", "win32"],
"parameters": ["headful"],
"expectations": ["FAIL"]
},
{
"testIdPattern": "[emulation-focus.spec.ts] *",
"platforms": ["darwin", "linux", "win32"],
Expand Down
67 changes: 44 additions & 23 deletions src/PlaywrightSharp.Tests/ElementHandleWaitForElementStateTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
using System.Threading.Tasks;
using NUnit.Framework;
using PlaywrightSharp.Nunit;
using PlaywrightSharp.Tests.Attributes;
using PlaywrightSharp.Tests.BaseTests;

namespace PlaywrightSharp.Tests
Expand Down Expand Up @@ -76,9 +75,9 @@ public async Task ShouldWaitForAlreadyHidden()
await div.WaitForElementStateAsync(ElementState.Hidden);
}

[PlaywrightTest("elementhandle-wait-for-element-state.spec.ts", "should throw waiting for hidden when detached")]
[PlaywrightTest("elementhandle-wait-for-element-state.spec.ts", "should wait for hidden when detached")]
[Test, Timeout(TestConstants.DefaultTestTimeout)]
public async Task ShouldThrowWaitingForHiddenWhenDetached()
public async Task ShouldWaitForHiddenWhenDetached()
{
await Page.SetContentAsync("<div>content</div>");
var div = await Page.QuerySelectorAsync("div");
Expand All @@ -89,19 +88,6 @@ public async Task ShouldThrowWaitingForHiddenWhenDetached()
await task;
}

[PlaywrightTest("elementhandle-wait-for-element-state.spec.ts", "should wait for enabled button")]
[Test, Timeout(TestConstants.DefaultTestTimeout)]
public async Task ShouldWaitForEnabledButton()
{
await Page.SetContentAsync("<button disabled><span>Target</span></button>");
var span = await Page.QuerySelectorAsync("text=Target");
var task = span.WaitForElementStateAsync(ElementState.Enabled);
await GiveItAChanceToResolve(Page);
Assert.That(task.IsCompleted, Is.False);
await span.EvaluateAsync("span => span.parentElement.disabled = false");
await task;
}

[PlaywrightTest("elementhandle-wait-for-element-state.spec.ts", "should throw waiting for enabled when detached")]
[Test, Timeout(TestConstants.DefaultTestTimeout)]
public async Task ShouldThrowWaitingForEnabledWhenDetached()
Expand All @@ -114,21 +100,34 @@ public async Task ShouldThrowWaitingForEnabledWhenDetached()
Assert.That(exception.Message, Does.Contain("Element is not attached to the DOM"));
}

[PlaywrightTest("elementhandle-wait-for-element-state.spec.ts", "should wait for disabled button")]
[PlaywrightTest("elementhandle-wait-for-element-state.spec.ts", "should wait for aria enabled button")]
[Test, Timeout(TestConstants.DefaultTestTimeout)]
public async Task ShouldWaitForAriaEnabledButton()
{
await Page.SetContentAsync("<button aria-disabled=true><span>Target</span></button>");
var span = await Page.QuerySelectorAsync("text=Target");
var task = span.WaitForElementStateAsync(ElementState.Enabled);
await GiveItAChanceToResolve(Page);
Assert.That(task.IsCompleted, Is.False);
await span.EvaluateAsync("span => span.parentElement.setAttribute('aria-disabled', 'false')");
await task;
}

[PlaywrightTest("elementhandle-wait-for-element-state.spec.ts", "should wait for button with an aria-disabled parent")]
[Test, Timeout(TestConstants.DefaultTestTimeout)]
public async Task ShouldWaitForDisabledButton()
public async Task ShouldWaitForButtonWithAnAriaDisabledParent()
{
await Page.SetContentAsync("<button><span>Target</span></button>");
await Page.SetContentAsync("<div role=\"group\" aria-disabled=true><button><span>Target</span></button></div>");
var span = await Page.QuerySelectorAsync("text=Target");
var task = span.WaitForElementStateAsync(ElementState.Disabled);
var task = span.WaitForElementStateAsync(ElementState.Enabled);
await GiveItAChanceToResolve(Page);
Assert.That(task.IsCompleted, Is.False);
await span.EvaluateAsync("span => span.parentElement.disabled = true");
await span.EvaluateAsync("span => span.parentElement.parentElement.setAttribute('aria-disabled', 'false')");
await task;
}

[PlaywrightTest("elementhandle-wait-for-element-state.spec.ts", "should wait for stable position")]
[SkipBrowserAndPlatformFact(skipFirefox: true)]
[Test, Timeout(TestConstants.DefaultTestTimeout)]
public async Task ShouldWaitForStablePosition()
{
await Page.GoToAsync(TestConstants.ServerUrl + "/input/button.html");
Expand All @@ -137,20 +136,42 @@ await Page.EvalOnSelectorAsync("button", @"button => {
button.style.transition = 'margin 10000ms linear 0s';
button.style.marginLeft = '20000px';
}");

// rafraf for Firefox to kick in the animation.
await Rafraf(Page);
var task = button.WaitForElementStateAsync(ElementState.Stable);
await GiveItAChanceToResolve(Page);
Assert.That(task.IsCompleted, Is.False);
await button.EvaluateAsync("button => button.style.transition = ''");
await task;
}

[PlaywrightTest("elementhandle-wait-for-element-state.spec.ts", "should wait for editable input")]
[Test, Timeout(TestConstants.DefaultTestTimeout)]
public async Task ShouldWaitForEditableInput()
{
await Page.SetContentAsync("<input readonly>");
var input = await Page.QuerySelectorAsync("input");
var task = input.WaitForElementStateAsync(ElementState.Editable);
await GiveItAChanceToResolve(Page);
Assert.That(task.IsCompleted, Is.False);
await input.EvaluateAsync("input => input.readOnly = false");
await task;
}

private async Task GiveItAChanceToResolve(IPage page)
{
for (int i = 0; i < 5; i++)
{
await page.EvaluateAsync("() => new Promise(f => requestAnimationFrame(() => requestAnimationFrame(f)))");
}
}

private async Task Rafraf(IPage page, int count = 1)
{
for (int i = 0; i < count; i++)
{
await page.EvaluateAsync("() => new Promise(f => requestAnimationFrame(() => requestAnimationFrame(f)))");
}
}
}
}
Loading