Fix elementhandle-wait-for-element-state headful test failures#155
Closed
Fix elementhandle-wait-for-element-state headful test failures#155
Conversation
Update tests to match upstream Playwright: - Rename "should throw waiting for hidden when detached" to match upstream name - Replace "should wait for enabled button" with "should wait for aria enabled button" using aria-disabled attribute - Replace "should wait for disabled button" with "should wait for button with an aria-disabled parent" - Fix "should wait for stable position": add [Test, Timeout] attributes, add rafraf call before wait, remove Firefox skip - Add missing "should wait for editable input" test - Remove unused SkipBrowserAndPlatformFact import Remove wildcard headful expected failure for elementhandle-wait-for-element-state.spec.ts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ElementHandleWaitForElementStateTests.csto match upstream Playwright tests, fixing headful-mode failures[Test, Timeout]attributes (was missing[Test]), addedrafrafcall before starting wait (required for Firefox animation), removed incorrect Firefox skip[elementhandle-wait-for-element-state.spec.ts] *Closes #118
Test plan
dotnet build ./src/PlaywrightSharp.slnsucceedsHEADLESS=false PRODUCT=CHROMIUM dotnet test --filter "ClassName=PlaywrightSharp.Tests.ElementHandleWaitForElementStateTests"HEADLESS=false PRODUCT=FIREFOX dotnet test --filter "ClassName=PlaywrightSharp.Tests.ElementHandleWaitForElementStateTests"🤖 Generated with Claude Code