Skip to content

build: update generation config with protos from sdk-platform-java #12801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chingor13 wants to merge 3 commits into
base: main
Choose a base branch
from
+39 −1
Draft

build: update generation config with protos from sdk-platform-java #12801

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a54ad06
build: update generation config with protos from sdk-platform-java
chingor13 Apr 14, 2026
5c0fba9
rename common iam protos
chingor13 Apr 14, 2026
43a8bfe
skip showcase for now which requires showcase_mode
chingor13 Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 39 additions & 1 deletion generation_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3014,4 +3014,42 @@ libraries:
GAPICs:
- proto_path: google/cloud/workstations/v1
- proto_path: google/cloud/workstations/v1beta

- api_shortname: common-protos
name_pretty: Common Protos
product_documentation: https://github.com/googleapis/api-common-protos
api_description: Protobuf classes for Google's common protos.
release_level: stable
client_documentation: https://cloud.google.com/java/docs/reference/proto-google-common-protos/latest/history
distribution_name: com.google.api.grpc:proto-google-common-protos
excluded_dependencies: "proto-google-common-protos,grpc-google-common-protos,proto-google-common-protos-parent"
excluded_poms: "proto-google-common-protos-bom,proto-google-common-protos"
library_type: OTHER
GAPICs:
- proto_path: google/api
- proto_path: google/apps/card/v1
- proto_path: google/cloud
- proto_path: google/cloud/audit
- proto_path: google/cloud/location
- proto_path: google/geo/type
- proto_path: google/logging/type
- proto_path: google/longrunning
- proto_path: google/rpc
- proto_path: google/rpc/context
- proto_path: google/shopping/type
- proto_path: google/type
- api_shortname: common-iam
name_pretty: IAM
product_documentation: https://cloud.google.com/iam
api_description: Manages access control for Google Cloud Platform resources
release_level: stable
client_documentation: https://cloud.google.com/java/docs/reference/proto-google-iam-v1/latest/overview
distribution_name: com.google.api.grpc:proto-google-iam-v1
excluded_dependencies: "grpc-google-iam-v1"
excluded_poms: "proto-google-iam-v1-bom,google-iam-policy,proto-google-iam-v1"
library_type: OTHER
GAPICs:
- proto_path: google/iam/v1
- proto_path: google/iam/v2
- proto_path: google/iam/v2beta
- proto_path: google/iam/v3
- proto_path: google/iam/v3beta
Comment on lines +3046 to +3055
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The distribution_name is set to com.google.api.grpc:proto-google-iam-v1, but the GAPICs list includes proto paths for v2, v2beta, v3, and v3beta. This inconsistency can lead to confusion as the artifact name suggests it only contains v1 protos. Consider either splitting these into separate library entries (e.g., proto-google-iam-v2) or using a more generic distribution name if bundling multiple versions is intended.

Loading