build: update generation config with protos from sdk-platform-java#12801
build: update generation config with protos from sdk-platform-java#12801
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds configurations for the Showcase, Common Protos, and IAM APIs to the generation configuration. Review feedback highlights an inconsistency in the IAM distribution name, which suggests only version 1 is included despite the presence of versions 2 and 3. Additionally, a placeholder URL in the Showcase product documentation needs to be replaced with a valid link.
| distribution_name: com.google.api.grpc:proto-google-iam-v1 | ||
| excluded_dependencies: "grpc-google-iam-v1" | ||
| excluded_poms: "proto-google-iam-v1-bom,google-iam-policy,proto-google-iam-v1" | ||
| library_type: OTHER | ||
| GAPICs: | ||
| - proto_path: google/iam/v1 | ||
| - proto_path: google/iam/v2 | ||
| - proto_path: google/iam/v2beta | ||
| - proto_path: google/iam/v3 | ||
| - proto_path: google/iam/v3beta |
There was a problem hiding this comment.
The distribution_name is set to com.google.api.grpc:proto-google-iam-v1, but the GAPICs list includes proto paths for v2, v2beta, v3, and v3beta. This inconsistency can lead to confusion as the artifact name suggests it only contains v1 protos. Consider either splitting these into separate library entries (e.g., proto-google-iam-v2) or using a more generic distribution name if bundling multiple versions is intended.
1 participant
Fixes #12735