chore: cleanup release-please config #1852
Merged
+21
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove redundant options already declared at the top level. - Remove bumpMinorPreMajor for repositories after the first major release.
|
lqiu96
reviewed
Dec 9, 2025
Comment on lines
+5
to
+15
| - branch: 0.25.2-sp | ||
| releaseType: java-lts | ||
| - branch: java7 | ||
| - branch: 1.2.x | ||
| releaseType: java-backport | ||
| - branch: 1.12.x | ||
| releaseType: java-backport | ||
| - branch: 1.6.x | ||
| releaseType: java-backport | ||
| - branch: 1.19.x | ||
| releaseType: java-backport |
Member
There was a problem hiding this comment.
not something we need to fix in here, but I assume that quite a few of these versions are no longer needed. Do you know which versions we can just remove from here?
Contributor
Author
There was a problem hiding this comment.
I'm not aware of which versions are outdated. I'll create a tracking ticket for this.
lqiu96
approved these changes
Dec 9, 2025
blakeli0
approved these changes
Jan 12, 2026
blakeli0
requested changes
Jan 12, 2026
Contributor
blakeli0
left a comment
blakeli0
left a comment
There was a problem hiding this comment.
I don't see bumpMinorPreMajor anymore, is it the default behavior?
Contributor
Author
The branches will inherit the |
blakeli0
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the .github/release-please.yml file by removing redundant options and the bump-minor-pre-major setting for major releases.