Skip to content

Refactor regexes and mappings class and constants.#3789

Open
silvio2402 wants to merge 2 commits into
masterfrom
refactor-regex-consts-cpp
Open

Refactor regexes and mappings class and constants.#3789
silvio2402 wants to merge 2 commits into
masterfrom
refactor-regex-consts-cpp

Conversation

@silvio2402

Copy link
Copy Markdown
Contributor

This is part 1 of the refactoring related to b/370922064.

  • Refactor the PhoneNumberRegExpsAndMappings class and its helper functions to a new regexpsandmappings.cc file.
  • Move helper functions ExtnDigits and CreateExtnPattern into the PhoneNumberRegExpsAndMappings class.
  • Move helper function PrefixNumberWithCountryCallingCode into the PhoneNumberUtil class.
  • Refactor some common constants to constants.h.
  • Add a test for getting an example number for a type that only exists for a non-geo entity.

@markusicu

Copy link
Copy Markdown

@roubert @google/libphonenumber could this PR be reviewed & merged?
I would like to modernize/simplify the character constants & escapes in a follow-up change.

@markusicu

Copy link
Copy Markdown

see the Google-internal change number 716145382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants