Skip to content

Refactor regexes and mappings class and constants.#3785

Closed
silvio2402 wants to merge 1 commit into
google:masterfrom
silvio2402:refactors
Closed

Refactor regexes and mappings class and constants.#3785
silvio2402 wants to merge 1 commit into
google:masterfrom
silvio2402:refactors

Conversation

@silvio2402

Copy link
Copy Markdown
Contributor

This is part 1 of the refactoring related to b/370922064.

  • Refactor the PhoneNumberRegExpsAndMappings class and its helper functions to a new regexpsandmappings.cc file.
  • Move helper functions ExtnDigits and CreateExtnPattern into the PhoneNumberRegExpsAndMappings class.
  • Move helper function PrefixNumberWithCountryCallingCode into the PhoneNumberUtil class.
  • Refactor some common constants to constants.h.
  • Add a test for getting an example number for a type that only exists for a non-geo entity.

@silvio2402 silvio2402 requested a review from tvislavski January 16, 2025 09:43
@silvio2402 silvio2402 requested a review from a team as a code owner January 16, 2025 09:43
@silvio2402

Copy link
Copy Markdown
Contributor Author

Refer to new PR: #3789

@silvio2402 silvio2402 closed this Jan 22, 2025
@silvio2402 silvio2402 deleted the refactors branch January 29, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant