Skip to content

Add comment around default network of docker on getIpAddr of docker.go #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0405ysj merged 1 commit into from
Mar 6, 2026
+13 −0
Merged

Add comment around default network of docker on getIpAddr of docker.go #511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions pkg/app/instances/docker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ import (

const DockerIMType IMType = "docker"

// A DockerIMConfig contains configuration needs for Docker instance manager.
//
// While the container image name is configurable, we do not intend or want to
// support other containers or alternative command execution in the
// `cuttlefish-orchestration` container.
type DockerIMConfig struct {
DockerImageName string
HostOrchestratorPort int
Expand Down Expand Up @@ -269,6 +274,8 @@ func (m *DockerInstanceManager) getHostURL(host string) (*url.URL, error) {
return url.Parse(fmt.Sprintf("%s://%s:%d", m.Config.HostOrchestratorProtocol, addr, port))
}

// When creating docker instances as default, docker instance gets belonged
// to the default network named 'bridge' with getting an assigned IP.
func (m *DockerInstanceManager) GetHostClient(zone string, host string) (HostClient, error) {
if zone != "local" {
return nil, errors.NewBadRequestError("Invalid zone. It should be 'local'.", nil)
Expand Down Expand Up @@ -365,6 +372,12 @@ func (m *DockerInstanceManager) createDockerVolumeIfNeeded(ctx context.Context,
return nil
}

// The container is expected to have:
// - An entrypoint starting cuttlefish-host_orchestrator service and its
// dependencies.
// - Network access through default docker0 bridge interface.
// - A volume named with `user_artifacts_<username>` for sharing user
// artifacts across containers.
func (m *DockerInstanceManager) createDockerContainer(ctx context.Context, user accounts.User) (string, error) {
config := &container.Config{
AttachStdin: true,
Expand Down
Loading