Skip to content

Add comment around default network of docker on getIpAddr of docker.go#511

Open
0405ysj wants to merge 1 commit intogoogle:mainfrom
0405ysj:co_doc
Open

Add comment around default network of docker on getIpAddr of docker.go#511
0405ysj wants to merge 1 commit intogoogle:mainfrom
0405ysj:co_doc

Conversation

@0405ysj
Copy link
Collaborator

@0405ysj 0405ysj commented Feb 25, 2026

No description provided.

@0405ysj 0405ysj force-pushed the co_doc branch 2 times, most recently from e9d516c to 807de99 Compare February 26, 2026 00:58
@0405ysj
Copy link
Collaborator Author

0405ysj commented Mar 4, 2026

@3405691582 Gentle ping, would this be good to merge or I need more modifications?

@3405691582
Copy link
Collaborator

Sorry, I forgot to submit the comment.

Comment on lines +43 to 53
// A DockerIMConfig contains configuration needs for Docker instance manager.
type DockerIMConfig struct {
DockerImageName string
// DockerImageName is the name and tag of docker image to use. For example,
// `cuttlefish-orchestration:latest`.
// We don't intend to support any customized docker images except
// `cuttlefish-orchestration`, which contains Host Orchestrator in it.
DockerImageName string
// HostOrchestratorPort is the port number of Host Orchestrator running on
// the docker instance.
HostOrchestratorPort int
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The internal commentary is unnecessary. I think this should be enough:

Suggested change
// A DockerIMConfig contains configuration needs for Docker instance manager.
type DockerIMConfig struct {
DockerImageName string
// DockerImageName is the name and tag of docker image to use. For example,
// `cuttlefish-orchestration:latest`.
// We don't intend to support any customized docker images except
// `cuttlefish-orchestration`, which contains Host Orchestrator in it.
DockerImageName string
// HostOrchestratorPort is the port number of Host Orchestrator running on
// the docker instance.
HostOrchestratorPort int
}
// A DockerIMConfig contains configuration needs for Docker instance manager.
//
// While the container image name is configurable, we do not intend or want
// to support other containers or alternative command execution in
// the `cuttlefish-orchestration` container.
type DockerIMConfig struct {
DockerImageName string
HostOrchestratorPort int
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants