Skip to content

fix: align tool context use #4339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vvaswani wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −1
Open

fix: align tool context use #4339

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce31ffe
fix: align tool context use
vvaswani Jan 31, 2026
ca1d8c7
add feedback
vvaswani Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/google/adk/tools/mcp_tool/mcp_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,16 @@ async def run_async(
self, *, args: dict[str, Any], tool_context: ToolContext
) -> Any:
if isinstance(self._require_confirmation, Callable):
args_to_call = args
try:
signature = inspect.signature(self._require_confirmation)
if "tool_context" in signature.parameters:
args_to_call = args.copy()
args_to_call["tool_context"] = tool_context
except (TypeError, ValueError):
pass
require_confirmation = await self._invoke_callable(
self._require_confirmation, args
self._require_confirmation, args_to_call
)
else:
require_confirmation = bool(self._require_confirmation)
Expand Down