Skip to content

Update vertex_ai_session_service.py #3026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yeesian wants to merge 2 commits into from
Closed

Update vertex_ai_session_service.py #3026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a74053
Update vertex_ai_session_service.py
yeesian Sep 26, 2025
a1adbd7
Update pyproject.toml
yeesian Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ dependencies = [
"google-cloud-spanner>=3.56.0, <4.0.0", # For Spanner database
"google-cloud-speech>=2.30.0, <3.0.0", # For Audio Transcription
"google-cloud-storage>=2.18.0, <3.0.0", # For GCS Artifact service
# TODO: Modify genai version constraint after the connector/client session warning is fixed.
"google-genai>=1.21.1, <1.37.0", # Google GenAI SDK
"google-genai @ git+https://github.com/googleapis/python-genai.git@copybara/811800162", # For testing purposes
"graphviz>=0.20.2, <1.0.0", # Graphviz for graph rendering
"mcp>=1.8.0, <2.0.0;python_version>='3.10'", # For MCP Toolset
"opentelemetry-api>=1.37.0, <=1.37.0", # OpenTelemetry - limit upper version for sdk and api to not risk breaking changes from unstable _logs package.
Expand Down
4 changes: 2 additions & 2 deletions src/google/adk/sessions/vertex_ai_session_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,9 +377,9 @@ def _get_api_client(self):
It needs to be instantiated inside each request so that the event loop
management can be properly propagated.
"""
api_client = genai.Client(
api_client = genai.client.BaseApiClient(
vertexai=True, project=self._project, location=self._location
)._api_client
)
Comment on lines +380 to +382
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change to use genai.client.BaseApiClient directly is a good improvement for maintainability. To make this even more robust, consider passing http_options to the BaseApiClient constructor. This would allow removing the subsequent modification of the private _http_options attribute, making the code cleaner and less coupled to the library's internal implementation.


if new_options := self._api_client_http_options_override():
api_client._http_options = new_options
Expand Down