-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Update vertex_ai_session_service.py #3026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @yeesian, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the internal API client initialization within the Vertex AI session service. The change simplifies how the underlying API client is obtained, moving from an indirect access through a wrapper client to a direct instantiation of the base client. This improves clarity and potentially efficiency in client management. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the API client instantiation in vertex_ai_session_service.py to avoid using a private _api_client attribute. This is a good improvement for maintainability. My review includes a suggestion to further improve the method by also removing another private attribute access, if possible.
| api_client = genai.client.BaseApiClient( | ||
| vertexai=True, project=self._project, location=self._location | ||
| )._api_client | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change to use genai.client.BaseApiClient directly is a good improvement for maintainability. To make this even more robust, consider passing http_options to the BaseApiClient constructor. This would allow removing the subsequent modification of the private _http_options attribute, making the code cleaner and less coupled to the library's internal implementation.
|
This is meant for testing purposes, and not for merging |
No description provided.