Skip to content

Do not report extremely high HeartbeatLag values until the first heartbeat is read #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meiji163 merged 1 commit into from
May 19, 2026
+4 −0
Merged

Do not report extremely high HeartbeatLag values until the first heartbeat is read #1682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions go/logic/migrator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,7 @@ func (mgtr *Migrator) checkAbort() error {
func (mgtr *Migrator) Migrate() (err error) {
mgtr.migrationContext.Log.Infof("Migrating %s.%s", sql.EscapeName(mgtr.migrationContext.DatabaseName), sql.EscapeName(mgtr.migrationContext.OriginalTableName))
mgtr.migrationContext.StartTime = time.Now()
mgtr.migrationContext.SetLastHeartbeatOnChangelogTime(mgtr.migrationContext.StartTime)

// Ensure context is cancelled on exit (cleanup)
defer mgtr.migrationContext.CancelContext()
Expand Down Expand Up @@ -667,6 +668,7 @@ func (mgtr *Migrator) Revert() error {
sql.EscapeName(mgtr.migrationContext.DatabaseName), sql.EscapeName(mgtr.migrationContext.OriginalTableName),
sql.EscapeName(mgtr.migrationContext.DatabaseName), sql.EscapeName(mgtr.migrationContext.OldTableName))
mgtr.migrationContext.StartTime = time.Now()
mgtr.migrationContext.SetLastHeartbeatOnChangelogTime(mgtr.migrationContext.StartTime)

// Ensure context is cancelled on exit (cleanup)
defer mgtr.migrationContext.CancelContext()
Expand Down
2 changes: 2 additions & 0 deletions go/logic/migrator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -990,6 +990,7 @@ func (suite *MigratorTestSuite) TestRevertEmpty() {
err = migrator.Migrate()
oldTableName = migrationContext.GetOldTableName()
suite.Require().NoError(err)
suite.Require().Less(migrationContext.TimeSinceLastHeartbeatOnChangelog(), 24*time.Hour)
}

// revert the original migration
Expand All @@ -1008,6 +1009,7 @@ func (suite *MigratorTestSuite) TestRevertEmpty() {

err = migrator.Revert()
suite.Require().NoError(err)
suite.Require().Less(migrationContext.TimeSinceLastHeartbeatOnChangelog(), 24*time.Hour)
}
}

Expand Down
Loading