Do not report extremely high HeartbeatLag values until the first heartbeat is read#1682
Open
grodowski wants to merge 1 commit into
Open
Do not report extremely high HeartbeatLag values until the first heartbeat is read#1682grodowski wants to merge 1 commit into
grodowski wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents HeartbeatLag from showing extremely large values caused by an uninitialized lastHeartbeatOnChangelogTime before the first heartbeat event is processed, by initializing the value when a migration/revert starts.
Changes:
- Initialize
lastHeartbeatOnChangelogTimetoStartTimeat the beginning ofMigrator.Migrate()andMigrator.Revert(). - Add assertions in
TestRevertEmptyto ensureTimeSinceLastHeartbeatOnChangelog()is reasonable afterMigrate()and afterRevert().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go/logic/migrator.go | Initializes heartbeat timestamp at start of migrate/revert to avoid reporting uninitialized lag. |
| go/logic/migrator_test.go | Adds regression assertions to catch uninitialized/huge heartbeat lag durations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Discovered it's possible to log uninitialized time values of
lastHeartbeatOnChangelogTimebefore the first heartbeat arrives.In case this PR introduced Go code changes:
script/cibuildreturns with no formatting errors, build errors or unit test errors.