Skip to content

C++: Fix FPs in cpp/wrong-number-format-arguments #17906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
calumgrant merged 2 commits into from
Nov 7, 2024
Merged

C++: Fix FPs in cpp/wrong-number-format-arguments #17906

calumgrant merged 2 commits into from
Nov 7, 2024

Conversation

@calumgrant
Copy link
Contributor

@calumgrant calumgrant commented Nov 4, 2024

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

@github-actions github-actions bot added the C++ label Nov 4, 2024
@calumgrant
Copy link
Contributor Author

calumgrant commented Nov 5, 2024

DCA results look good - lost results are all FPs.

geoffw0
geoffw0 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look reasonable as well. 👍

@calumgrant calumgrant marked this pull request as ready for review November 6, 2024 11:42
@calumgrant calumgrant requested a review from a team as a code owner November 6, 2024 11:42
@calumgrant calumgrant added the no-change-note-required This PR does not need a change note label Nov 6, 2024
@calumgrant calumgrant merged commit 39b2d2c into main Nov 7, 2024
1 of 2 checks passed
@calumgrant calumgrant deleted the calumgrant/bmn/wrong-number-format-args branch November 7, 2024 15:05
jketema added a commit to jketema/codeql that referenced this pull request Nov 28, 2024
@jketema
Revert "Merge pull request github#17906 from github/calumgrant/bmn/wr…
ed0b78d 
…ong-number-format-args"

This reverts commit 39b2d2c, reversing
changes made to a35a4b2.
jketema added a commit to jketema/codeql that referenced this pull request Nov 28, 2024
@jketema
Revert "Merge pull request github#17906 from github/calumgrant/bmn/wr…
a55c2fb 
…ong-number-format-args"

This reverts commit 39b2d2c, reversing
changes made to a35a4b2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geoffw0 geoffw0 geoffw0 approved these changes

Assignees

No one assigned

Labels

C++ no-change-note-required This PR does not need a change note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@calumgrant @geoffw0