Revert "Merge pull request github#17906 from github/calumgrant/bmn/wrong-number-format-args"

This reverts commit 39b2d2c, reversing
changes made to a35a4b2.

Author: jketema

cpp/ql/src/Likely Bugs/Format/WrongNumberOfFormatArguments.ql

@@ -16,20 +16,6 @@
 
 import cpp
 
-class SyntaxError extends CompilerError {
-  SyntaxError() { this.getTag().matches("exp_%") }
-
-  predicate affects(Element e) {
-    exists(Location l1, Location l2 |
-      l1 = this.getLocation() and
-      l2 = e.getLocation()
-    |
-      l1.getFile() = l2.getFile() and
-      l1.getStartLine() = l2.getStartLine()
-    )
-  }
-}
-
 from FormatLiteral fl, FormattingFunctionCall ffc, int expected, int given, string ffcName
 where
   ffc = fl.getUse() and
@@ -41,10 +27,7 @@ where
     if ffc.isInMacroExpansion()
     then ffcName = ffc.getTarget().getName() + " (in a macro expansion)"
     else ffcName = ffc.getTarget().getName()
-  ) and
-  // A typical problem is that string literals are concatenated, but if one of the string
-  // literals is an undefined macro, then this just leads to a syntax error.
-  not exists(SyntaxError e | e.affects(fl))
+  )
 select ffc,
   "Format for " + ffcName + " expects " + expected.toString() + " arguments but given " +
     given.toString()