Skip to content

ref(workerchild): add distribution metric for pending futures #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmckerry wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

ref(workerchild): add distribution metric for pending futures #671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions clients/python/src/taskbroker_client/worker/workerchild.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,16 @@ def await_task_futures(task: ActivationWithPendingFutures) -> None:

def check_task_future_completion() -> None:
if len(pending_task_futures) > 0:
# Records a distribution of how many activations with pending producer futures
# a processing pool has across all worker child processes.
# Only reports if the worker actually has pending futures.
metrics.distribution(
"taskworker.worker.activations_with_pending_futures",
len(pending_task_futures),
tags={
"processing_pool": processing_pool_name,
},
)
for task in pending_task_futures.copy():
if all([f.done() for f in task.pending_futures]):
await_task_futures(task)
Expand Down
Loading