ref(workerchild): add distribution metric for pending futures#671
Open
bmckerry wants to merge 1 commit into
Open
ref(workerchild): add distribution metric for pending futures#671bmckerry wants to merge 1 commit into
bmckerry wants to merge 1 commit into
Conversation
Member
You could log both? One would tell you the total/p99, and the other would tell you how many produce futures a single workerchild has to deal with. |
bmckerry
force-pushed
the
task-producer-metrics
branch
from
484f749 to
1965973
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1965973. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
untitaker
approved these changes
Jun 3, 2026
| # Records a distribution of how many activations with pending producer futures | ||
| # a processing pool has across all worker child processes. | ||
| # Only reports if the worker actually has pending futures. | ||
| metrics.distribution( |
Member
There was a problem hiding this comment.
i suspect this should be a gauge?
bmckerry
force-pushed
the
task-producer-metrics
branch
from
1965973 to
82be624
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a metric to get a picture of how many activations with pending futures a processing pool has.
Originally I was going to make this a
gaugeto get a view of the total pending activations in a processing pool, but I don't think that'd actually work (since we run many worker child processes and don't have a way to distinguish them in tags). I think making this a distribution tagged by processing pool will let us get ap95view of how many pending activations a pool has, which is also useful.