fix: Remove faulty token validation for symbol upload#2537
fix: Remove faulty token validation for symbol upload#2537bitsandfoxes merged 4 commits intomainfrom
Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| var isOrgAuthToken = cliOptions.IsOrgAuthToken(); | ||
| if (isOrgAuthToken) | ||
| { | ||
| EditorGUILayout.HelpBox( |
There was a problem hiding this comment.
Org Slug error icon removed instead of simplified
Medium Severity
The Org Slug field's GUIContent lost its ErrorIcon argument entirely. The Auth Token and Project Name fields both still show SentryWindow.ErrorIcon when UploadSymbols is enabled and the value is empty, but the Org Slug field no longer does. The old code conditionally showed the icon via !isOrgAuthToken; removing the org-auth-token logic means the condition simplifies to cliOptions.UploadSymbols && string.IsNullOrWhiteSpace(cliOptions.Organization), but instead the whole icon expression was dropped.


The
DebugSymbolsTabdisables the org slug field when it detects an org auth token viaStartsWith("sntrys_"). But token validation and org extraction in sentry-cli consists of three different parts, checking forStartsWith("sntrys_")just being one of them.This means a token can pass the prefix check yet still fail sentry-cli's own parsing — leaving the user with a disabled org field and no way to provide the org slug as a fallback.
This removes the
IsOrgAuthToken()prefix check and the special handling around the org field: no more disabling it, no more info help box, no more error icon. The wizard will still only fill theauth tokensince it reliably fetches the correct one. But the SDK will no longer hinder users from filling the org field as a fallback.