Skip to content

Commit 2e40558

Browse files
authored
fix: Remove faulty token validation for symbol upload (#2537)
1 parent 1cfa533 commit 2e40558

3 files changed

Lines changed: 4 additions & 17 deletions

File tree

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
## Unreleased
44

5+
### Fixes
6+
7+
- The SDK no longer wrongly disables the org slug field based on assumed the auth-tolken type ([#2537](https://github.com/getsentry/sentry-unity/pull/2537))
8+
59
### Dependencies
610

711
- Bump Cocoa SDK from v9.4.0 to v9.4.1 ([#2540](https://github.com/getsentry/sentry-unity/pull/2540))

src/Sentry.Unity.Editor/ConfigurationWindow/DebugSymbolsTab.cs

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -35,27 +35,12 @@ internal static void Display(SentryCliOptions cliOptions)
3535
"The authorization token from your user settings in Sentry"),
3636
cliOptions.Auth);
3737

38-
// Org tokens have a `sntrys` prefix and do not require an organisation
39-
var isOrgAuthToken = cliOptions.IsOrgAuthToken();
40-
if (isOrgAuthToken)
41-
{
42-
EditorGUILayout.HelpBox(
43-
"Organization Auth Token detected. The token's embedded 'org slug' will be used during " +
44-
"symbol upload.",
45-
MessageType.Info);
46-
}
47-
48-
EditorGUI.BeginDisabledGroup(isOrgAuthToken);
49-
5038
cliOptions.Organization = EditorGUILayout.TextField(
5139
new GUIContent(
5240
"Org Slug",
53-
cliOptions.UploadSymbols && string.IsNullOrWhiteSpace(cliOptions.Organization) && !isOrgAuthToken ? SentryWindow.ErrorIcon : null,
5441
"The organization slug in Sentry"),
5542
cliOptions.Organization);
5643

57-
EditorGUI.EndDisabledGroup();
58-
5944
cliOptions.Project = EditorGUILayout.TextField(
6045
new GUIContent(
6146
"Project Name",

src/Sentry.Unity/SentryCliOptions.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ internal static string GetConfigPath(string? notDefaultConfigName = null)
3131
private static void MissingFieldWarning(IDiagnosticLogger? logger, string name) =>
3232
logger?.LogWarning("{0} missing. Please set it under {1}", name, EditorMenuPath);
3333

34-
public bool IsOrgAuthToken() => Auth is not null && Auth.StartsWith("sntrys_");
35-
3634
public bool IsValid(IDiagnosticLogger? logger, bool isDevelopmentBuild)
3735
{
3836
if (!UploadSymbols)

0 commit comments

Comments
 (0)