-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(browser): Add replay.logs.metrics bundle
#19021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,6 +29,9 @@ | |
| "test:bundle:tracing_logs_metrics": "PW_BUNDLE=bundle_tracing_logs_metrics yarn test", | ||
| "test:bundle:tracing_logs_metrics:min": "PW_BUNDLE=bundle_tracing_logs_metrics_min yarn test", | ||
| "test:bundle:tracing_logs_metrics:debug_min": "PW_BUNDLE=bundle_tracing_logs_metrics_debug_min yarn test", | ||
| "test:bundle:replay_logs_metrics": "PW_BUNDLE=bundle_replay_logs_metrics yarn test", | ||
| "test:bundle:replay_logs_metrics:min": "PW_BUNDLE=bundle_replay_logs_metrics_min yarn test", | ||
| "test:bundle:replay_logs_metrics:debug_min": "PW_BUNDLE=bundle_replay_logs_metrics_debug_min yarn test", | ||
|
Comment on lines
+33
to
+34
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. l: Same here, can we move them up? |
||
| "test:bundle:full": "PW_BUNDLE=bundle_tracing_replay_feedback yarn test", | ||
| "test:bundle:full:min": "PW_BUNDLE=bundle_tracing_replay_feedback_min yarn test", | ||
| "test:bundle:tracing_replay_feedback_logs_metrics": "PW_BUNDLE=bundle_tracing_replay_feedback_logs_metrics yarn test", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -62,6 +62,9 @@ const BUNDLE_PATHS: Record<string, Record<string, string>> = { | |
| bundle_tracing_logs_metrics: 'build/bundles/bundle.tracing.logs.metrics.js', | ||
| bundle_tracing_logs_metrics_min: 'build/bundles/bundle.tracing.logs.metrics.min.js', | ||
| bundle_tracing_logs_metrics_debug_min: 'build/bundles/bundle.tracing.logs.metrics.debug.min.js', | ||
| bundle_replay_logs_metrics: 'build/bundles/bundle.replay.logs.metrics.js', | ||
| bundle_replay_logs_metrics_min: 'build/bundles/bundle.replay.logs.metrics.min.js', | ||
| bundle_replay_logs_metrics_debug_min: 'build/bundles/bundle.replay.logs.metrics.debug.min.js', | ||
|
Comment on lines
+65
to
+67
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. l: Can we move these up to bunch them up with the other |
||
| bundle_tracing_replay: 'build/bundles/bundle.tracing.replay.js', | ||
| bundle_tracing_replay_min: 'build/bundles/bundle.tracing.replay.min.js', | ||
| bundle_tracing_replay_feedback: 'build/bundles/bundle.tracing.replay.feedback.js', | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import { browserTracingIntegrationShim, feedbackIntegrationShim } from '@sentry-internal/integration-shims'; | ||
|
|
||
| export * from './index.bundle.base'; | ||
|
|
||
| // TODO(v11): Export metrics here once we remove it from the base bundle. | ||
| export { logger, consoleLoggingIntegration } from '@sentry/core'; | ||
|
|
||
| export { replayIntegration, getReplay } from '@sentry-internal/replay'; | ||
|
|
||
| export { | ||
| browserTracingIntegrationShim as browserTracingIntegration, | ||
| feedbackIntegrationShim as feedbackAsyncIntegration, | ||
| feedbackIntegrationShim as feedbackIntegration, | ||
| }; |
17 changes: 17 additions & 0 deletions
17
packages/browser/test/index.bundle.replay.logs.metrics.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { logger as coreLogger, metrics as coreMetrics } from '@sentry/core'; | ||
| import { browserTracingIntegrationShim, feedbackIntegrationShim } from '@sentry-internal/integration-shims'; | ||
| import { describe, expect, it } from 'vitest'; | ||
| import { replayIntegration } from '../src'; | ||
| import * as ReplayLogsMetricsBundle from '../src/index.bundle.replay.logs.metrics'; | ||
|
|
||
| describe('index.bundle.replay.logs.metrics', () => { | ||
| it('has correct exports', () => { | ||
| expect(ReplayLogsMetricsBundle.browserTracingIntegration).toBe(browserTracingIntegrationShim); | ||
| expect(ReplayLogsMetricsBundle.feedbackAsyncIntegration).toBe(feedbackIntegrationShim); | ||
| expect(ReplayLogsMetricsBundle.feedbackIntegration).toBe(feedbackIntegrationShim); | ||
| expect(ReplayLogsMetricsBundle.replayIntegration).toBe(replayIntegration); | ||
|
|
||
| expect(ReplayLogsMetricsBundle.logger).toBe(coreLogger); | ||
| expect(ReplayLogsMetricsBundle.metrics).toBe(coreMetrics); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l: Can we move this up to bunch it up with
bundle_replay_instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one more bundle to add and will sort them there to not run the whole ci again 👍