Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -570,6 +570,7 @@ jobs:
- bundle_tracing
- bundle_logs_metrics
- bundle_tracing_logs_metrics
- bundle_replay_logs_metrics
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: Can we move this up to bunch it up with bundle_replay_ instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one more bundle to add and will sort them there to not run the whole ci again 👍

- bundle_tracing_replay
- bundle_tracing_replay_feedback
- bundle_tracing_replay_feedback_min
Expand Down
13 changes: 13 additions & 0 deletions .size-limit.js
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,12 @@ module.exports = [
gzip: true,
limit: '44 KB',
},
{
name: 'CDN Bundle (incl. Replay, Logs, Metrics)',
path: createCDNPath('bundle.replay.logs.metrics.min.js'),
gzip: true,
limit: '69 KB',
},
{
name: 'CDN Bundle (incl. Tracing, Replay)',
path: createCDNPath('bundle.tracing.replay.min.js'),
Expand Down Expand Up @@ -245,6 +251,13 @@ module.exports = [
brotli: false,
limit: '130 KB',
},
{
name: 'CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed',
path: createCDNPath('bundle.replay.logs.metrics.min.js'),
gzip: false,
brotli: false,
limit: '209 KB',
},
{
name: 'CDN Bundle (incl. Tracing, Replay) - uncompressed',
path: createCDNPath('bundle.tracing.replay.min.js'),
Expand Down
3 changes: 3 additions & 0 deletions dev-packages/browser-integration-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@
"test:bundle:tracing_logs_metrics": "PW_BUNDLE=bundle_tracing_logs_metrics yarn test",
"test:bundle:tracing_logs_metrics:min": "PW_BUNDLE=bundle_tracing_logs_metrics_min yarn test",
"test:bundle:tracing_logs_metrics:debug_min": "PW_BUNDLE=bundle_tracing_logs_metrics_debug_min yarn test",
"test:bundle:replay_logs_metrics": "PW_BUNDLE=bundle_replay_logs_metrics yarn test",
"test:bundle:replay_logs_metrics:min": "PW_BUNDLE=bundle_replay_logs_metrics_min yarn test",
"test:bundle:replay_logs_metrics:debug_min": "PW_BUNDLE=bundle_replay_logs_metrics_debug_min yarn test",
Comment on lines +33 to +34
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: Same here, can we move them up?

"test:bundle:full": "PW_BUNDLE=bundle_tracing_replay_feedback yarn test",
"test:bundle:full:min": "PW_BUNDLE=bundle_tracing_replay_feedback_min yarn test",
"test:bundle:tracing_replay_feedback_logs_metrics": "PW_BUNDLE=bundle_tracing_replay_feedback_logs_metrics yarn test",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ const BUNDLE_PATHS: Record<string, Record<string, string>> = {
bundle_tracing_logs_metrics: 'build/bundles/bundle.tracing.logs.metrics.js',
bundle_tracing_logs_metrics_min: 'build/bundles/bundle.tracing.logs.metrics.min.js',
bundle_tracing_logs_metrics_debug_min: 'build/bundles/bundle.tracing.logs.metrics.debug.min.js',
bundle_replay_logs_metrics: 'build/bundles/bundle.replay.logs.metrics.js',
bundle_replay_logs_metrics_min: 'build/bundles/bundle.replay.logs.metrics.min.js',
bundle_replay_logs_metrics_debug_min: 'build/bundles/bundle.replay.logs.metrics.debug.min.js',
Comment on lines +65 to +67
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: Can we move these up to bunch them up with the other bundle_replay bundles instead?

bundle_tracing_replay: 'build/bundles/bundle.tracing.replay.js',
bundle_tracing_replay_min: 'build/bundles/bundle.tracing.replay.min.js',
bundle_tracing_replay_feedback: 'build/bundles/bundle.tracing.replay.feedback.js',
Expand Down
8 changes: 8 additions & 0 deletions packages/browser/rollup.bundle.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,13 @@ const tracingLogsMetricsBaseBundleConfig = makeBaseBundleConfig({
outputFileBase: () => 'bundles/bundle.tracing.logs.metrics',
});

const replayLogsMetricsBaseBundleConfig = makeBaseBundleConfig({
bundleType: 'standalone',
entrypoints: ['src/index.bundle.replay.logs.metrics.ts'],
licenseTitle: '@sentry/browser (Replay, Logs, and Metrics)',
outputFileBase: () => 'bundles/bundle.replay.logs.metrics',
});

const tracingReplayFeedbackLogsMetricsBaseBundleConfig = makeBaseBundleConfig({
bundleType: 'standalone',
entrypoints: ['src/index.bundle.tracing.replay.feedback.logs.metrics.ts'],
Expand All @@ -135,6 +142,7 @@ builds.push(
...makeBundleConfigVariants(tracingReplayFeedbackBaseBundleConfig),
...makeBundleConfigVariants(logsMetricsBaseBundleConfig),
...makeBundleConfigVariants(tracingLogsMetricsBaseBundleConfig),
...makeBundleConfigVariants(replayLogsMetricsBaseBundleConfig),
...makeBundleConfigVariants(tracingReplayFeedbackLogsMetricsBaseBundleConfig),
);

Expand Down
14 changes: 14 additions & 0 deletions packages/browser/src/index.bundle.replay.logs.metrics.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import { browserTracingIntegrationShim, feedbackIntegrationShim } from '@sentry-internal/integration-shims';

export * from './index.bundle.base';

// TODO(v11): Export metrics here once we remove it from the base bundle.
export { logger, consoleLoggingIntegration } from '@sentry/core';

export { replayIntegration, getReplay } from '@sentry-internal/replay';

export {
browserTracingIntegrationShim as browserTracingIntegration,
feedbackIntegrationShim as feedbackAsyncIntegration,
feedbackIntegrationShim as feedbackIntegration,
};
17 changes: 17 additions & 0 deletions packages/browser/test/index.bundle.replay.logs.metrics.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { logger as coreLogger, metrics as coreMetrics } from '@sentry/core';
import { browserTracingIntegrationShim, feedbackIntegrationShim } from '@sentry-internal/integration-shims';
import { describe, expect, it } from 'vitest';
import { replayIntegration } from '../src';
import * as ReplayLogsMetricsBundle from '../src/index.bundle.replay.logs.metrics';

describe('index.bundle.replay.logs.metrics', () => {
it('has correct exports', () => {
expect(ReplayLogsMetricsBundle.browserTracingIntegration).toBe(browserTracingIntegrationShim);
expect(ReplayLogsMetricsBundle.feedbackAsyncIntegration).toBe(feedbackIntegrationShim);
expect(ReplayLogsMetricsBundle.feedbackIntegration).toBe(feedbackIntegrationShim);
expect(ReplayLogsMetricsBundle.replayIntegration).toBe(replayIntegration);

expect(ReplayLogsMetricsBundle.logger).toBe(coreLogger);
expect(ReplayLogsMetricsBundle.metrics).toBe(coreMetrics);
});
});
Loading