feat(browser): Add replay.logs.metrics bundle
#19021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
chargome
requested review from
Lms24 and
andreiborza
and removed request for
andreiborza
andreiborza
approved these changes
Jan 28, 2026
| - bundle_tracing | ||
| - bundle_logs_metrics | ||
| - bundle_tracing_logs_metrics | ||
| - bundle_replay_logs_metrics |
Member
There was a problem hiding this comment.
l: Can we move this up to bunch it up with bundle_replay_ instead?
Member
Author
There was a problem hiding this comment.
I have one more bundle to add and will sort them there to not run the whole ci again 👍
Comment on lines
+65
to
+67
| bundle_replay_logs_metrics: 'build/bundles/bundle.replay.logs.metrics.js', | ||
| bundle_replay_logs_metrics_min: 'build/bundles/bundle.replay.logs.metrics.min.js', | ||
| bundle_replay_logs_metrics_debug_min: 'build/bundles/bundle.replay.logs.metrics.debug.min.js', |
Member
There was a problem hiding this comment.
l: Can we move these up to bunch them up with the other bundle_replay bundles instead?
Comment on lines
+33
to
+34
| "test:bundle:replay_logs_metrics:min": "PW_BUNDLE=bundle_replay_logs_metrics_min yarn test", | ||
| "test:bundle:replay_logs_metrics:debug_min": "PW_BUNDLE=bundle_replay_logs_metrics_debug_min yarn test", |
Member
There was a problem hiding this comment.
l: Same here, can we move them up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19003