-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(browser): Add logs.metrics bundle
#19020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { | ||
| browserTracingIntegrationShim, | ||
| feedbackIntegrationShim, | ||
| replayIntegrationShim, | ||
| } from '@sentry-internal/integration-shims'; | ||
|
|
||
| export * from './index.bundle.base'; | ||
|
|
||
| // TODO(v11): Export metrics here once we remove it from the base bundle. | ||
| export { logger, consoleLoggingIntegration } from '@sentry/core'; | ||
|
|
||
| export { | ||
| browserTracingIntegrationShim as browserTracingIntegration, | ||
| feedbackIntegrationShim as feedbackAsyncIntegration, | ||
| feedbackIntegrationShim as feedbackIntegration, | ||
| replayIntegrationShim as replayIntegration, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import { logger as coreLogger, metrics as coreMetrics } from '@sentry/core'; | ||
| import { describe, expect, it } from 'vitest'; | ||
| import * as LogsMetricsBundle from '../src/index.bundle.logs.metrics'; | ||
|
|
||
| describe('index.bundle.logs.metrics', () => { | ||
| it('has correct exports', () => { | ||
| expect(LogsMetricsBundle.logger).toBe(coreLogger); | ||
| expect(LogsMetricsBundle.metrics).toBe(coreMetrics); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit test is incomplete compared to existing patterns
Low Severity · Bugbot Rules
The unit test only verifies
loggerandmetricsexports, but all other bundle tests (e.g.,index.bundle.test.ts,index.bundle.tracing.test.ts,index.bundle.tracing.logs.metrics.test.ts) also verify that integration shims are correctly exported. This test is missing assertions forbrowserTracingIntegration,feedbackIntegration,feedbackAsyncIntegration,replayIntegration(all should be shims), andconsoleLoggingIntegration(should be the real implementation). This violates the review rule to "check that tests actually test the newly added behaviour" - incomplete coverage could miss regressions where shims are accidentally replaced with real implementations.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is simply not true.