feat(browser): Add logs.metrics bundle
#19020
Conversation
size-limit report 📦
|
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
chargome
requested review from
Lms24 and
andreiborza
and removed request for
andreiborza
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| expect(LogsMetricsBundle.logger).toBe(coreLogger); | ||
| expect(LogsMetricsBundle.metrics).toBe(coreMetrics); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Unit test is incomplete compared to existing patterns
Low Severity · Bugbot Rules
The unit test only verifies logger and metrics exports, but all other bundle tests (e.g., index.bundle.test.ts, index.bundle.tracing.test.ts, index.bundle.tracing.logs.metrics.test.ts) also verify that integration shims are correctly exported. This test is missing assertions for browserTracingIntegration, feedbackIntegration, feedbackAsyncIntegration, replayIntegration (all should be shims), and consoleLoggingIntegration (should be the real implementation). This violates the review rule to "check that tests actually test the newly added behaviour" - incomplete coverage could miss regressions where shims are accidentally replaced with real implementations.
There was a problem hiding this comment.
That is simply not true.
closes #19002