chore(release): Add generate-changelog script #18999
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| const processDetailsContent = (): void => { | ||
| for (const line of detailsContent) { | ||
| const trimmed = line.trim(); | ||
| if (trimmed.startsWith('-') && trimmed.includes('(#')) { |
There was a problem hiding this comment.
Internal changelog entries missed due to incorrect PR format check
Medium Severity
The check trimmed.includes('(#') in processDetailsContent fails to match entries with the markdown link format. The actual changelog format is ([#18750](url)) where [ appears between ( and #, so the substring (# is never present. This causes internal entries from <details> blocks to be silently ignored - they won't appear in output and their PR numbers won't be tracked in changelogPRs, potentially leading to duplicate entries when the same commits exist in the git log.
| } else { | ||
| otherChanges.push(entry); | ||
| } | ||
| } |
There was a problem hiding this comment.
Missing PR tracking causes duplicate git commit entries
Medium Severity
The duplicate detection logic checks if a PR number exists in changelogPRs but never adds newly processed PR numbers to the set. If multiple commits in the git log reference the same PR number (which can happen with cherry-picks or amended commits), all of them will be added to the output as duplicates. After adding each commit's entry, its prNumber needs to be added to changelogPRs to prevent subsequent commits with the same PR from also being included.
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
JPeer264
left a comment
JPeer264
left a comment
There was a problem hiding this comment.
Let's try this out in the next release. LGTM
I know we'll be using the craft release notes soon, but this can be beneficial for the time being. I've never had a lot of luck with the cursor command and this deterministic script might help other people as well.
Closes #19000 (added automatically)