Restore span names for GraphQL on the new version of OpenTelemetry (by changing OpenTelemetry defaults)

[adinauer]

📜 Description

GraphQL span names in OpenTelemetry have been changed to just query from e.g. query GreetingQuery for this query:

query GreetingQuery($name: String) {
    greeting(name: $name)
}

This PR uses span attributes to restore the previous op and description for Sentry spans by changing the following config of the OpenTelemetry SDK to restore previous behaviour:

System.setProperty("otel.instrumentation.graphql.add-operation-name-to-span-name.enabled", "true");

More info:

• Remove operation name from graphql span name open-telemetry/opentelemetry-java-instrumentation#13794
• feat!: Update GraphQL span name convention open-telemetry/semantic-conventions#1389

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

• I added tests to verify the changes.
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
• I updated the docs if needed.
• I updated the wizard if needed.
• Review from the native team if needed.
• No breaking change or entry added to the changelog.
• No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

[github-actions]

	Fails
🚫	Please consider adding a changelog entry for the next release.

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Restore span names for GraphQL on the new version of OpenTelemetry (by changing OpenTelemetry defaults) ([#4537](https://github.com/getsentry/sentry-java/pull/4537))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 4f5e29d

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	359.33 ms	377.26 ms	17.93 ms
Size	1.58 MiB	2.09 MiB	519.08 KiB

Baseline results on branch: feat/bump-otel-1_51_0

Startup times

Revision	Plain	With Sentry	Diff
228dd89	449.13 ms	465.16 ms	16.04 ms
f2bb552	412.40 ms	417.63 ms	5.23 ms

App size

Revision	Plain	With Sentry	Diff
228dd89	1.58 MiB	2.09 MiB	518.90 KiB
f2bb552	1.58 MiB	2.09 MiB	518.90 KiB

Previous results on branch: feat/otel-bump-graphql-op-fix-change-otel-defaults

Startup times

Revision	Plain	With Sentry	Diff
8053e0b	409.17 ms	452.52 ms	43.35 ms
33c64d6	419.66 ms	488.46 ms	68.80 ms
3a46437	386.28 ms	408.67 ms	22.39 ms

App size

Revision	Plain	With Sentry	Diff
8053e0b	1.58 MiB	2.09 MiB	519.08 KiB
33c64d6	1.58 MiB	2.09 MiB	519.07 KiB
3a46437	1.58 MiB	2.09 MiB	519.08 KiB

[lcian]

Wrong branch I think, anyway I understand the approach.
Would it be possible for the user to override our choice of otel.instrumentation.graphql.add-operation-name-to-span-name.enabled? Or would we be forcing it to true regardless of what the user sets?

[adinauer]

Wrong branch I think, anyway I understand the approach.

Fixed

[lcian]

Nice, I prefer this option as it allows the user to easily override it, it's more transparent, and less code to maintain.