Restore span names for GraphQL on the new version of OpenTelemetry (via SpanDescriptionExtractor)#4535
Closed
adinauer wants to merge 4 commits intofeat/bump-otel-1_51_0from
Closed
Restore span names for GraphQL on the new version of OpenTelemetry (via SpanDescriptionExtractor)#4535adinauer wants to merge 4 commits intofeat/bump-otel-1_51_0from
SpanDescriptionExtractor)#4535adinauer wants to merge 4 commits intofeat/bump-otel-1_51_0from
Conversation
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Restore span names for GraphQL on the new version of OpenTelemetry (via `SpanDescriptionExtractor`) ([#4535](https://github.com/getsentry/sentry-java/pull/4535))If none of the above apply, you can opt out of this check by adding |
Contributor
Performance metrics 🚀
|
Member
Author
|
Could also set: |
SpanDescriptionExtractor)
Member
Author
|
We have decided to go with #4537 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
GraphQL span names in OpenTelemetry have been changed to just
queryfrom e.g.query GreetingQueryfor this query:This PR uses span attributes to restore the previous
opanddescriptionfor Sentry spans.More info:
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps