Fix mixed cname with separate version argument parsing

.github/actions/features_parse/action.yml

@@ -11,7 +11,7 @@ outputs:
 runs:
   using: composite
   steps:
-    - uses: gardenlinux/python-gardenlinux-lib/.github/actions/setup@0.8.7
+    - uses: gardenlinux/python-gardenlinux-lib/.github/actions/setup@0.8.8
     - id: result
       shell: bash
       run: |

.github/actions/flavors_parse/action.yml

@@ -13,7 +13,7 @@ outputs:
 runs:
   using: composite
   steps:
-    - uses: gardenlinux/python-gardenlinux-lib/.github/actions/setup@0.8.7
+    - uses: gardenlinux/python-gardenlinux-lib/.github/actions/setup@0.8.8
     - id: matrix
       shell: bash
       run: |

.github/actions/setup/action.yml

@@ -3,7 +3,7 @@ description: Installs the given GardenLinux Python library
 inputs:
     version:
         description: GardenLinux Python library version
-        default: "0.8.7"
+        default: "0.8.8"
 runs:
     using: composite
     steps:

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "gardenlinux"
-version = "0.8.7"
+version = "0.8.8"
 description = "Contains tools to work with the features directory of gardenlinux, for example deducting dependencies from feature sets or validating cnames"
 authors = ["Garden Linux Maintainers <contact@gardenlinux.io>"]
 license = "Apache-2.0"

src/gardenlinux/features/__main__.py

@@ -6,6 +6,7 @@
 """
 
 import argparse
+import logging
 import os
 import re
 import sys
@@ -65,24 +66,30 @@ def main() -> None:
         args.cname
     ), "Please provide either `--features` or `--cname` argument"
 
-    arch = None
+    arch = args.arch
     flavor = None
     commit_id = None
     gardenlinux_root = path.dirname(args.feature_dir)
-    version = None
-
-    if args.arch is not None:
-        arch = args.arch
-
-    if args.version is not None:
-        version = args.version
+    version = args.version
 
     if arch is None or arch == "":
         arch = args.default_arch
 
+    if gardenlinux_root == "":
+        gardenlinux_root = "."
+
     if version is None or version == "":
-        version_data = get_version_and_commit_id_from_files(gardenlinux_root)
-        version = f"{version_data[0]}-{version_data[1]}"
+        try:
+            version_data = get_version_and_commit_id_from_files(gardenlinux_root)
+            version = f"{version_data[0]}-{version_data[1]}"
+        except RuntimeError as exc:
+            logging.debug(
+                "Failed to parse version information for GL root '{0}': {1}".format(
+                    gardenlinux_root, exc
+                )
+            )
+
+            version = args.default_version
 
     if args.cname:
         cname = CName(args.cname, arch=arch, version=version)
@@ -106,12 +113,6 @@ def main() -> None:
 
     feature_dir_name = path.basename(args.feature_dir)
 
-    if gardenlinux_root == "":
-        gardenlinux_root = "."
-
-    if gardenlinux_root == "":
-        gardenlinux_root = "."
-
     additional_filter_func = lambda node: node not in args.ignore
 
     if args.type == "arch":
@@ -199,6 +200,9 @@ def get_version_and_commit_id_from_files(gardenlinux_root: str) -> tuple[str, st
         with open(path.join(gardenlinux_root, "VERSION"), "r") as fp:
             version = fp.read().strip()
 
+    if commit_id is None or version is None:
+        raise RuntimeError("Failed to read version or commit ID from files")
+
     return (version, commit_id)
 
 

src/gardenlinux/features/cname_main.py

@@ -8,6 +8,7 @@
 from functools import reduce
 from os.path import basename, dirname
 import argparse
+import logging
 import re
 
 from .cname import CName
@@ -44,19 +45,23 @@ def main():
 
     assert re_match, f"Not a valid GardenLinux canonical name {args.cname}"
 
-    arch = None
+    arch = args.arch
     gardenlinux_root = dirname(args.feature_dir)
     version = args.version
 
-    if args.arch is not None:
-        arch = args.arch
-
-    if args.version is not None:
-        version = args.version
+    if gardenlinux_root == "":
+        gardenlinux_root = "."
 
     if not version:
-        version_data = get_version_and_commit_id_from_files(gardenlinux_root)
-        version = f"{version_data[0]}-{version_data[1]}"
+        try:
+            version_data = get_version_and_commit_id_from_files(gardenlinux_root)
+            version = f"{version_data[0]}-{version_data[1]}"
+        except RuntimeError as exc:
+            logging.warning(
+                "Failed to parse version information for GL root '{0}': {1}".format(
+                    gardenlinux_root, exc
+                )
+            )
 
     cname = CName(args.cname, arch=arch, version=version)