Fix mixed cname with separate version argument parsing#129
Merged
NotTheEvilOne merged 2 commits intomainfrom Jul 31, 2025
Merged
Fix mixed cname with separate version argument parsing#129NotTheEvilOne merged 2 commits intomainfrom
cname with separate version argument parsing#129NotTheEvilOne merged 2 commits intomainfrom
Conversation
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
NotTheEvilOne
force-pushed
the
fix/cname-parser-fine-tuning
branch
from
95a7ce0 to
97e65f6
Compare
ByteOtter
requested changes
Jul 28, 2025
Contributor
ByteOtter
left a comment
ByteOtter
left a comment
There was a problem hiding this comment.
As far as I can tell, this looks good. Just one nitpick from my side. :)
NotTheEvilOne
force-pushed
the
fix/cname-parser-fine-tuning
branch
from
f79b7a9 to
c328b46
Compare
ByteOtter
requested changes
Jul 31, 2025
Contributor
ByteOtter
left a comment
ByteOtter
left a comment
There was a problem hiding this comment.
Thanks for taking my suggestion to heart. I still have some thoughts about the silent pass though.
Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
NotTheEvilOne
force-pushed
the
fix/cname-parser-fine-tuning
branch
from
c328b46 to
b32c701
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR enhances handling corner cases of flavors given as input and
archand/orversion(as well as "default"-argument variants) to return the expected GardenLinux canonical name. Changes are code cleanup related and fix a possible error thatNone-Noneis not a valid version.This PR merged code should be tagged "0.8.8".