Some minor code cleanup

lib/ArithmeticGroups/barycentric.gi

@@ -8,7 +8,7 @@ InstallGlobalFunction(HAP_BaryCentricSubdivisionGComplex,
 function(C)
 local Cells,coBoundaries,N,i,Dims,pos,j,x,y,w,id,t,k,ck,c,s,a,v,g,b,
     Elts,Rep,mult,ListUnion, Chains, IsSameOrbit, AddReturn,
-    Orbit, Dimension, StabRec, Action, Stabilizer, Boundary,
+    Orbit, Dimension, StabRec, action, Stabilizer, Boundary,
     NChains, BoundaryRec, FinalBoundary;
 
 
@@ -224,9 +224,9 @@ local Cells,coBoundaries,N,i,Dims,pos,j,x,y,w,id,t,k,ck,c,s,a,v,g,b,
     return StabRec[k+1][i];
     end;
 
-# The cell structure is rigid under the action of G then Action(k,i,j) always be 1.
+# The cell structure is rigid under the action of G then action(k,i,j) always be 1.
 
-    Action:=function(k,i,j)
+    action:=function(k,i,j)
     return 1;
     end;
 
@@ -254,7 +254,7 @@ return Objectify(HapNonFreeResolution,
     elts:=Elts,
     group:=C!.group,
     stabilizer:=Stabilizer,
-    action:=Action,
+    action:=action,
     properties:=
     [["length",Maximum(1000,N)],
     ["characteristic",0],
@@ -268,7 +268,7 @@ end);
 InstallMethod(BarycentricSubdivision,
 "for non-free resolutions",
 [IsHapNonFreeResolution],
-function(R);
+function(R)
 return HAP_BaryCentricSubdivisionGComplex(R);
 end);
 #########################################################

lib/ArithmeticGroups/cplGTree.gi

@@ -18,7 +18,7 @@ function(m,p)
 local t1,t2,
     Elts,H,K,G,Gamma,
     Id,ID,Idcoset,BoundaryList,
-    Boundary,Dimension,Action,Stabilizer,Homotopy,StabGrps,
+    Boundary,Dimension,action,Stabilizer,Homotopy,StabGrps,
     pos,RemoveLoops,HtpyRec;
 
     Elts:=[[[1,0],[0,1]]];
@@ -121,13 +121,13 @@ local t1,t2,
 
     ###################################################################     
     #1
-    #F  Action
+    #F  action
     ##
     ##  Input:  a triple (n,k,l) of integers
     ##          
     ##  Output: 1 or -1  
     ##
-    Action:=function(n,k,l);
+    action:=function(n,k,l)
         return 1;
     end;
     ###################################################################
@@ -144,7 +144,7 @@ local t1,t2,
     ##          
     ##  Output: the kith stabiliser subgroup in dimension n   
     ##
-    Stabilizer:=function(n,k);
+    Stabilizer:=function(n,k)
         return StabGrps[n+1][k];
     end;
     ###################################################################
@@ -281,7 +281,7 @@ return Objectify(HapNonFreeResolution,
     elts:=Elts,
     group:=G,
     stabilizer:=Stabilizer,
-    action:=Action,
+    action:=action,
     properties:=
     [["length",100],
     ["characteristic",0],

lib/ArithmeticGroups/crystGcomplex.gi

@@ -12,7 +12,7 @@
 InstallGlobalFunction(CrystGcomplex,
 function(gens,basis,check)
 local i,x,k,combin,n,j,r,m,vect,c,
-    B,G,T,S,Bt,Action,Sign,FinalBoundary,BoundaryList,
+    B,G,T,S,Bt,action,Sign,FinalBoundary,BoundaryList,
     L,kcells,cells,w,StabGrp,ActionRecord,lnth,PseudoRotSubGroup,
     RotSubGroupList,
     Dimension,SearchOrbit,pos,StabilizerOfPoint,PseudoBoundary,
@@ -218,7 +218,7 @@ kcells:=tmp;
     end;
     ###################################################################
 
-# Create a record for the Action 
+# Create a record for the action 
     ActionRecord:=[];
     for m in [1..lnth+1] do
         ActionRecord[m]:=[];
@@ -252,13 +252,13 @@ kcells:=tmp;
 
     ###################################################################     
     #1
-    #F  Action
+    #F  action
     ##
     ##  Input:  Degree m, position k of a generator and position g of 
     ##          an element.                
     ##  Output: 1 or -1.
     ##
-    Action:=function(m,k,g)
+    action:=function(m,k,g)
     local id,r,u,H,abk,ans,x,h,l,i;
 
         abk:=AbsInt(k);
@@ -293,7 +293,7 @@ kcells:=tmp;
 
     ###################################################################     
     #1
-    #F  Action
+    #F  action
     ##
     ##  Input:  Degree m, position k of a generator and position g of 
     ##          an element.                
@@ -666,7 +666,7 @@ kcells:=tmp;
             elts:=Elts,
             group:=G,
             stabilizer:=Stabilizer,
-            action:=Action,
+            action:=action,
         RotSubGroup:=RotSubGroup,
         Bool:=Bool,      #####ADDED OCTOBER 2024
             properties:=

lib/ArithmeticGroups/crystGcomplex.original.tuan

@@ -12,7 +12,7 @@
 InstallGlobalFunction(CrystGcomplex,
 function(gens,basis,check)
 local i,x,k,combin,n,j,r,m,vect,c,
-    B,G,T,S,Bt,Action,Sign,FinalBoundary,BoundaryList,
+    B,G,T,S,Bt,action,Sign,FinalBoundary,BoundaryList,
     L,kcells,cells,w,StabGrp,ActionRecord,lnth,PseudoRotSubGroup,
     RotSubGroupList,
     Dimension,SearchOrbit,pos,StabilizerOfPoint,PseudoBoundary,
@@ -170,7 +170,7 @@ local i,x,k,combin,n,j,r,m,vect,c,
     end;
     ###################################################################
 
-# Create a record for the Action 
+# Create a record for the action 
     ActionRecord:=[];
     for m in [1..lnth+1] do
         ActionRecord[m]:=[];
@@ -204,13 +204,13 @@ local i,x,k,combin,n,j,r,m,vect,c,
 
     ###################################################################     
     #1
-    #F  Action
+    #F  action
     ##
     ##  Input:  Degree m, position k of a generator and position g of 
     ##          an element.                
     ##  Output: 1 or -1.
     ##
-    Action:=function(m,k,g)
+    action:=function(m,k,g)
     local id,r,u,H,abk,ans,x,h,l,i;
 
         abk:=AbsInt(k);
@@ -245,7 +245,7 @@ local i,x,k,combin,n,j,r,m,vect,c,
 
     ###################################################################     
     #1
-    #F  Action
+    #F  action
     ##
     ##  Input:  Degree m, position k of a generator and position g of 
     ##          an element.                
@@ -617,7 +617,7 @@ local i,x,k,combin,n,j,r,m,vect,c,
             elts:=Elts,
             group:=G,
             stabilizer:=Stabilizer,
-            action:=Action,
+            action:=action,
         RotSubGroup:=RotSubGroup,
             properties:=
             [["length",100],

lib/ArithmeticGroups/freeZGRes.gi

@@ -19,7 +19,7 @@ local
     Boundary, BoundaryP, Pair2Quad, Pair2QuadRec,
     Quad2Pair,Quad2PairRec, HtpyGen, HtpyWord,
     StabGrps, StabResls, ResolutionFG,
-    Action, AlgRed,  EltsG, G, Mult, MultRecord,
+    action, AlgRed,  EltsG, G, Mult, MultRecord,
     DelGen, DelWord, DelGenRec,PseudoBoundary,FinalBoundary,
     FilteredLength, FilteredDimension, FilteredDimensionRecord,
     L,i,k,n,q,r,s,t,
@@ -185,9 +185,9 @@ local
 
     ###################################################################
     if IsBound(P!.action) and not prime=2 then 
-        Action:=P!.action;
+        action:=P!.action;
     else 
-        Action:=function(k,j,g) return 1; end;
+        action:=function(k,j,g) return 1; end;
     fi;
     ###################################################################
 
@@ -276,7 +276,7 @@ local
 
     DimensionRecord:=List([0..N],Dimension);
 
-    Dimension:=function(k);
+    Dimension:=function(k)
         return DimensionRecord[k+1];
     end;
     ###################################################################
@@ -437,9 +437,9 @@ local
 
         h:=[];
         for y in w do
-            x:=[Action(q,y[1],y[3])*y[1],y[2],y[3]];
+            x:=[action(q,y[1],y[3])*y[1],y[2],y[3]];
             z:=HtpyGen(q,s,x[1],x[2],x[3]);
-            z:=List(z,a->[Action(q,a[1],a[3])*a[1],a[2],a[3]]);
+            z:=List(z,a->[action(q,a[1],a[3])*a[1],a[2],a[3]]);
             Append(h,z);
         od;
 
@@ -502,7 +502,7 @@ local
                 return [];
             else
                 y:=List(StabResls[q+1][pr]!.boundary(s,pt),
-                        x->[Action(q,r,x[2])*x[1],x[2]]);
+                        x->[action(q,r,x[2])*x[1],x[2]]);
                 if pt>0 then
                     DelGenRec[k+1][q+1][s+1][pr][pt]:= 
                             AlgRed(List(y,x->[pr,x[1],x[2]]));
@@ -676,7 +676,7 @@ local
     FilteredLength:=Maximum(Flat(FiltDimRecs));
 
     ###################################################################
-    FilteredDimension:=function(r,k);
+    FilteredDimension:=function(r,k)
 
         return Length(Filtered(FiltDimRecs[k+1],x->x<=r));
 
@@ -823,9 +823,9 @@ local
         h,x,y,v;
         h:=[];;
         for x in w do
-            v:=[x[1],x[2],Action(x[1],x[3],x[5])*x[3],x[4],x[5]];
+            v:=[x[1],x[2],action(x[1],x[3],x[5])*x[3],x[4],x[5]];
             y:=StructuralCopy(HtpyGen(v[1],v[2],v[3],v[4],v[5]));
-            Apply(y,a->[x[1],x[2]+1,Action(x[1],a[1],a[3])*a[1],a[2],a[3]]);
+            Apply(y,a->[x[1],x[2]+1,action(x[1],a[1],a[3])*a[1],a[2],a[3]]);
             Append(h,y);
         od;    
     return h;

lib/ArithmeticGroups/gchaincomplex.gi

@@ -32,7 +32,7 @@ end);
 ######################################################
 GChainComplex:=function(K,G)
 local Ksimps,R, orbits, stabilizers, stabfn, Dim, lessthan, boundfn,
-elts, i, k, x, m,Action ,ontuples;
+elts, i, k, x, m,action ,ontuples;
 
 elts:=Elements(G);
 Ksimps:=[];
@@ -41,7 +41,7 @@ Ksimps[k]:=List(K!.simplicesLst[k],x->StructuralCopy(x));
 od;
 
 #############################
-Action:=function(a,b,c) return 1; end;
+action:=function(a,b,c) return 1; end;
 #############################
 
 #############################
@@ -72,14 +72,14 @@ stabilizers[k][i]:=Stabilizer(G,orbits[k][i][1],ontuples);
 od;od;
 
 ######################
-Dim:=function(k);
+Dim:=function(k)
 if k<0 or k>Dimension(K) then return 0; fi;
 return Length(orbits[k+1]);
 end;
 ######################
 
 ######################
-stabfn:=function(k,i);
+stabfn:=function(k,i)
 return stabilizers[k+1][i];
 end;
 ######################
@@ -126,7 +126,7 @@ R:=Objectify(HapGChainComplex,
             elts:=Elements(G),
             group:=G,
             stabilizer:=stabfn,
-            action:=Action,
+            action:=action,
             properties:=
             [["length",Dimension(K)],
              ["characteristic",0]]));

lib/ArithmeticGroups/resGTree.gi

@@ -19,7 +19,7 @@ local
 	StabRes,StabGrps,Triple2Pair,Quad2One,GrpsRes,Pair2Quad,Quad2Pair,
 	Dimension,Hmap,Gmult,Gmultrec,Mult,AlgRed,CorrectList,Boundary,
 	Homotopy,FinalHomotopy,
-	StRes,hmap,Action,PseudoBoundary,PseudoHomotopy, ZeroDimensionHmap, 
+	StRes,hmap,action,PseudoBoundary,PseudoHomotopy, ZeroDimensionHmap, 
         ZeroDimensionHtpy,
 	HmapRec,p,q,r,s,HtpyRec,k,g, ZeroDimensionHmapRec, Pair2QuadRec,
         QuadToPairRec,DimensionRec;
@@ -30,13 +30,13 @@ local
 
     ###################################################################     
     #1
-    #F  Action
+    #F  action
     ##
     ##  Input:  a triple of integers (p,r,q)
     ##  Output: 1 or -1 
     ##
 
-    Action:=function(p,r,g)
+    action:=function(p,r,g)
     if not IsBound(R!.action) then 
         return 1;
     else 
@@ -262,7 +262,7 @@ local
             else
                 l:=[];m:=[];
                 d0:=StructuralCopy(List(StabRes[p+1][r]!.boundary(q,ps),
-                                      x->[Action(p,r,x[2])*x[1],x[2]]));
+                                      x->[action(p,r,x[2])*x[1],x[2]]));
                 for w in d0 do
                     Append(m,Mult(w[2],Hmap(p,q-1,r,w[1])));
                 od;
@@ -400,7 +400,7 @@ local
         d:=[];
         if q<>0 then 
 	    l:=StructuralCopy(List(StabRes[p+1][r]!.boundary(q,s),
-              x->[Quad2Pair(p,q-1,r,Action(p,r,x[2])*x[1])[2],x[2]]));
+              x->[Quad2Pair(p,q-1,r,action(p,r,x[2])*x[1])[2],x[2]]));
             Append(d,StructuralCopy(l));
         fi;
         if IsEvenInt(q) then 
@@ -520,9 +520,9 @@ local
 	        Apply(h0,w->[Quad2Pair(p,q+1,r,w[1])[2],w[2]]);
 	        Append(h,h0);
 	        else
-	            ps:=Action(1,1,g)*s;
+	            ps:=action(1,1,g)*s;
 	            m:=StructuralCopy(StabRes[p+1][r]!.homotopy(q,[ps,g]));
-	            Apply(m,x->[Action(1,1,x[2])*x[1],x[2]]);
+	            Apply(m,x->[action(1,1,x[2])*x[1],x[2]]);
 	            h0:=List(m,x->[Quad2Pair(p,q+1,r,x[1])[2],x[2]]);
 	            Append(h,h0);
 	            dh:=AlgRed(CorrectList(List(m,x->