Skip to content

Some minor code cleanup #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
grahamknockillaree merged 2 commits into from
Dec 21, 2025
Merged

Some minor code cleanup #139

grahamknockillaree merged 2 commits into from
Dec 21, 2025

Conversation

@fingolfin
Copy link
Member

@fingolfin fingolfin commented Dec 21, 2025

  • Rename local variables Action to action
  • Remove redundant semicolons in function definitions

@fingolfin
Rename local variables Action to action
08de11b 
The GAP library defines a function `Action`. While using
its name for a local variable is perfectly legal, it still
makes it harder to test such code by copy&pasting it into a
GAP session. So for debugging it is still helpful to avoid
library names.
@fingolfin
Remove redundant semicolons in function definitions
e380092
@codecov
Copy link

codecov bot commented Dec 21, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.80%. Comparing base (d7b14c7) to head (e380092).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
lib/PolyComplexes/arrayOps.gi 30.00% 14 Missing ⚠️
lib/Perturbations/freeRes.gi 50.00% 4 Missing ⚠️
lib/PolyComplexes/simplicialComplexes.gi 20.00% 4 Missing ⚠️
lib/PolyComplexes/groupComplexes.gi 0.00% 3 Missing ⚠️
lib/ArithmeticGroups/resGTree.gi 50.00% 2 Missing ⚠️
lib/Functors/transfer.gi 0.00% 2 Missing ⚠️
lib/Perturbations/contractibleSL2ZcomplexALT.gi 0.00% 2 Missing ⚠️
lib/Perturbations/resDirectProd.gi 0.00% 2 Missing ⚠️
lib/RahmSanchez/DavisComplex.gi 0.00% 2 Missing ⚠️
lib/RegularCWComplexes/cocycle.gi 0.00% 2 Missing ⚠️
... and 20 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   44.73%   44.80%   +0.07%     
==========================================
  Files         345      345              
  Lines       64760    64228     -532     
==========================================
- Hits        28971    28779     -192     
+ Misses      35789    35449     -340
Files with missing lines Coverage Δ
lib/ArithmeticGroups/barycentric.gi 2.27% <ø> (+0.01%) ⬆️
lib/ArithmeticGroups/cplGTree.gi 1.14% <ø> (+0.01%) ⬆️
lib/ArithmeticGroups/crystGcomplex.gi 59.34% <ø> (ø)
lib/ArtinCoxeter/coxeterWythoff.gi 0.58% <ø> (+0.01%) ⬆️
lib/ArtinCoxeter/diagrams.gi 65.63% <ø> (+0.25%) ⬆️
lib/ArtinCoxeter/resArtin.gi 4.12% <ø> (+0.04%) ⬆️
lib/ArtinCoxeter/resArtin_spherical.gi 100.00% <ø> (ø)
lib/CatGroups/CatBasic.gi 26.97% <ø> (-0.48%) ⬇️
lib/CatGroups/CatConstructions.gi 35.71% <ø> (ø)
lib/CatGroups/algIdentities.gi 43.70% <ø> (-0.83%) ⬇️
... and 154 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@grahamknockillaree grahamknockillaree merged commit aae8964 into master Dec 21, 2025
6 of 7 checks passed
@grahamknockillaree grahamknockillaree deleted the mh/more-cleanup branch December 21, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fingolfin @grahamknockillaree