Skip to content

[Repo Assist] perf: cache Type.GetType calls in VerifyResultsetColumns #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[Repo Assist] perf: cache Type.GetType calls in VerifyResultsetColumns #454

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
add2e51
perf: cache Type.GetType calls in VerifyResultsetColumns
github-actions[bot] Mar 10, 2026
a9cc0df
ci: trigger checks
github-actions[bot] Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/SqlClient/ISqlCommand.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,8 @@ type ``ISqlCommand Implementation``(cfg: DesignTimeConfig, connection: Connectio

| unexpected -> failwithf "Unexpected ResultType value: %O" unexpected

static let typeCache = System.Collections.Concurrent.ConcurrentDictionary<string, Type>()

member this.CommandTimeout = cmd.CommandTimeout

interface ISqlCommand with
Expand Down Expand Up @@ -262,7 +264,8 @@ type ``ISqlCommand Implementation``(cfg: DesignTimeConfig, connection: Connectio
invalidOp message

for i = 0 to expected.Length - 1 do
let expectedName, expectedType = fst expected.[i], Type.GetType( snd expected.[i], throwOnError = true)
let expectedName, expectedTypeString = fst expected.[i], snd expected.[i]
let expectedType = typeCache.GetOrAdd(expectedTypeString, fun typeName -> Type.GetType(typeName, throwOnError = true))
let actualName, actualType = cursor.GetName( i), cursor.GetFieldType( i)
if actualName <> expectedName || actualType <> expectedType
then
Expand Down
Loading