[Repo Assist] perf: cache Type.GetType calls in VerifyResultsetColumns

[github-actions]

🤖 This is an automated PR from Repo Assist.

Summary

VerifyResultsetColumns is called on every Execute/AsyncExecute when runtime verification is enabled. It previously called Type.GetType(typeFullName, throwOnError = true) for every column in every result set on every execution, causing significant reflection overhead.

Root Cause

In ISqlCommand.fs line 265, the verification loop resolved types on each iteration:

for i = 0 to expected.Length - 1 do
    let expectedName, expectedType = fst expected.[i], Type.GetType( snd expected.[i], throwOnError = true)
    // ... verification logic

For a query returning 10 columns executed 1000 times, this meant 10,000 calls to Type.GetType — an expensive operation that involves assembly loading and type lookup.

Fix

Added a static ConcurrentDictionary(string, Type) cache (typeCache) to memoize type resolution:

static let typeCache = System.Collections.Concurrent.ConcurrentDictionary(string, Type)()

// In VerifyResultsetColumns:
let expectedType = typeCache.GetOrAdd(expectedTypeString, fun typeName -> Type.GetType(typeName, throwOnError = true))

The cache is thread-safe and shared across all command instances in the process.

Impact

• No behaviour change — semantics are identical; caching is transparent
• Performance: eliminates N×M reflection calls where N = columns and M = executions, after the first execution per unique type
• Memory: negligible — cache holds only Type references for types already in use

Test Status

Build: ✅ dotnet build src/SqlClient/SqlClient.fsproj -f netstandard2.0 succeeds (only pre-existing deprecation warnings).

Full integration tests require a SQL Server instance and could not be run in this environment. The change is a pure caching optimization with no logic change; existing tests will verify correctness.

Related

Complements PR #448 (TVP reflection caching). Together, these eliminate all hot-path reflection calls in ISqlCommand.fs.

Generated by Repo Assist · ◷

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@346204513ecfa08b81566450d7d599556807389f

Generated by Repo Assist · ◷

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@346204513ecfa08b81566450d7d599556807389f